test-assertions

Rewrite tests to use strict deep equality assertions everywhere.

This is a full rewrite, not incremental tweaking. Rethink each test holistically. Collapse multiple weak assertions about the same value into a single strict equality check against the complete expected value.

Assertion ranking (worst to best)

Only toStrictEqual is good enough. Everything else is too weak:

1. toBeTruthy, toBeDefined, not.toBeNull — barely checks anything
2. toHaveProperty('key') — only checks existence, not value
3. toContain, toMatch — substring/regex match hides the full value
4. toHaveLength(n) — only checks count, not contents
5. toMatchObject, objectContaining, arrayContaining — allows extra properties to sneak in
6. toEqual, to.deep.equal — close, but ignores class mismatches and undefined vs missing
7. toStrictEqual — the only acceptable assertion for objects and arrays

Scope

Determine which test files to rewrite:

• If $ARGUMENTS is provided, use that file or directory
• If $ARGUMENTS is empty and there are uncommitted changes, find test files among the unstaged/staged changes
• If $ARGUMENTS is empty and there are no uncommitted changes, find all test files in the project

Process

• Identify the target test file(s) using the scope rules above
• For each test, identify every assertion
• Replace weak assertions with a placeholder like expect(result).toStrictEqual({}) — do NOT guess the expected value from reading the implementation
• Run the test and let the error message reveal the actual value
• Copy the actual value from the error output into the assertion
• Run the test again to confirm it passes

What to rewrite

Multiple weak assertions on the same value become one strict assertion

// Before: three assertions that barely check anything
const result = await Children.run(['--json', '--projects-dir', '/tmp/fake-projects']);
expect(result).toHaveProperty('projects');
expect(result).toHaveProperty('summary');
expect(result.summary.total).toBe(2);

// Step 1: replace with placeholder — do NOT guess the expected value
expect(result).toStrictEqual({});

// Step 2: run the test, read the actual value from the error output, paste it in
expect(result).toStrictEqual({
	projects: [
		{name: 'project-a', path: '/tmp/fake-projects/project-a'},
		{name: 'project-b', path: '/tmp/fake-projects/project-b'},
	],
	summary: {total: 2, active: 2},
});