code-review

/codex:code-review — Codex correctness/security/reliability/simplification/performance review

Adversarially review the current branch's implementation diff: a Codex debate over correctness, security, reliability, simplification, and performance, looping until Codex approves. Codex is the hard gate. The command never commits — you do. Mechanics live in tested sr_* helpers; adjudicating findings and editing code is your (the agent's) job.

$ARGUMENTS (optional): [base] ref to diff against (default main).

Every shell block below runs under bash. codex-lib.sh and its helpers use bash arrays and abort under zsh/sh, so each block is wrapped in bash <<'CODEX_SH' … CODEX_SH — it runs under bash even when your default shell is zsh. And because each block runs in a fresh shell (sourced functions and vars do not persist between calls), every block re-resolves and re-sources the lib, then hands values to the next block through a per-repo state file (sr_state_file / sr_state_save / sr_state_load). The shared preamble — resolve LIB, source it, sr_state_load "$STATE" — opens every block.

Phase 0 — Resolve scope

bash <<'CODEX_SH'
# Resolve the plugin's lib + checklists. Order: installed plugin root, project-local
# checkout, a manual ~/.claude install, then the plugin cache (the unset-env
# fallback). First hit wins; CKDIR is its sibling.
LIB=""; CKDIR=""
for d in "${CLAUDE_PLUGIN_ROOT:-}" ".claude/commands/codex" "${CLAUDE_HOME:-$HOME/.claude}/commands/codex" $(printf '%s\n' "${CLAUDE_HOME:-$HOME/.claude}"/plugins/cache/*/codex/* 2>/dev/null | sort -Vr); do
  [ -n "$d" ] && [ -f "$d/codex-lib.sh" ] && { LIB="$d/codex-lib.sh"; CKDIR="$d/reference"; break; }
done
[ -n "$LIB" ] || { echo "codex-lib.sh missing — install the plugin or run install.sh"; exit 1; }
. "$LIB" || { echo "codex-lib.sh failed to source"; exit 1; }
command -v codex >/dev/null 2>&1 || { echo "codex CLI not on PATH"; exit 1; }
have="$(codex --version 2>/dev/null | grep -oE '[0-9]+\.[0-9]+\.[0-9]+' | head -1)"
sr_version_ge "${have:-0.0.0}" 0.140.0 || { echo "codex >= 0.140.0 required (have ${have:-none})"; exit 1; }

# Output mode. JSON (preferred): codex --output-schema returns schema-validated JSON,
# so structural parsing collapses to one sr_json_validate call — no fragile text grep.
# Falls back to markdown when no JSON parser (node), no schema file, or the schema is
# not strict-valid for codex (sr_schema_strict_ok) — so a bad schema degrades, not aborts.
# VFN/RFN/IDFN pick the parser so Phases 1.4/1.5 stay mode-agnostic.
SCHEMA=""; [ -n "$CKDIR" ] && SCHEMA="$(dirname "$CKDIR")/schemas/review-output.schema.json"
MODE=markdown; VFN=sr_parse_verdict; RFN=sr_round_findings; IDFN=sr_finding_ids
if sr_have_json && [ -f "$SCHEMA" ] && sr_schema_strict_ok "$SCHEMA"; then
  MODE=json; VFN=sr_json_verdict; RFN=sr_json_round_findings; IDFN=sr_json_finding_ids
fi

# args: token 1 = base ref (default main); token 2 = optional design-doc name hint
set -f; set -- ${ARGUMENTS:-}; set +f
BASE="${1:-main}"
SCOPE="$(sr_diff_scope "$BASE")" || { echo "cannot resolve scope vs '$BASE'"; exit 1; }
MB="$(printf '%s' "$SCOPE" | cut -f1)"
BRANCH="$(printf '%s' "$SCOPE" | cut -f2)"

PAYLOAD="$(sr_review_payload "$MB")"
if [ -z "$PAYLOAD" ]; then echo "Nothing to review (no changes vs $BASE)"; exit 0; fi

# design docs (spec + plan) — referenced by path for correctness/spec-compliance, not embedded
DESIGN="$(sr_design_docs "${2:-$BRANCH}")"
SPEC_DOC="$(printf '%s' "$DESIGN" | cut -f1)"
PLAN_DOC="$(printf '%s' "$DESIGN" | cut -f2)"

REPO="$(basename "$(git rev-parse --show-toplevel 2>/dev/null || pwd)")"
LOG="$(sr_log_path "${REPO}-$(sr_root_hash)" "$(sr_sanitize_name "$BRANCH")")"
LOG="${LOG/spec-review-/codex-review-}"   # code-review log namespace
DEP="$(sr_audit_summary)"
# Fresh-shell handoff: persist resolved scope for the debate-loop blocks.
STATE="$(sr_state_file code-review)"; : > "$STATE"
sr_state_save "$STATE" LIB CKDIR SCHEMA MODE VFN RFN IDFN BASE MB BRANCH SPEC_DOC PLAN_DOC REPO LOG DEP
echo "Scope:  $BASE...HEAD ($BRANCH)"
echo "Mode:   $MODE"
echo "Log:    $LOG"
echo "Design: ${SPEC_DOC:-(none)} | ${PLAN_DOC:-(none)}"
echo "$DEP"
CODEX_SH