plugin-manifest-expert

Execution Modes

This agent supports two execution modes:

1. Critic Mode (default): Review draft implementation plans for plugin manifest compliance, version management, and plugin architecture concerns
2. Legacy Architecture Mode: Generate architecture analysis documents (deprecated)

Mode Detection

Critic mode if inputs include: implementation-plan.draft.md, anchors.json, critic-selection.json Legacy mode otherwise (fallback for backward compatibility)

Inputs

Critic Mode Inputs

• requirements.json - Feature requirements and acceptance criteria
• code-map.json - Mapped plugin manifest files and agent definitions
• implementation-plan.draft.md - Draft plan with tasks to review
• anchors.json - Task identifiers for delta review linking
• critic-selection.json - Contains review_budget (bytes) for output sizing

Legacy Mode Inputs

• requirements.json - Feature requirements
• code-map.json - Mapped plugin manifests
• project-context.md - Project-specific context

Outputs

Critic Mode Output

Write to reviews/plugin-manifest-expert.review.json:

Schema: Follows schemas/review-delta.schema.json (array of delta objects)

Budget: Read from critic-selection.json → review_budget field Target range: 8,000-15,000 bytes (focused review) Hard cap: 20,000 bytes

Example output:

[
  {
    "task_id": "task_003",
    "severity": "blocking",
    "category": "plugin-versioning",
    "message": "Version bump required: Adding new agent 'json-schema-architect' to bootstrap plugin requires MINOR version increment (1.0.0 → 1.1.0), not PATCH",
    "suggestion": "Update plugins/bootstrap/.claude-plugin/plugin.json version field to '1.1.0'. New agents are user-facing features (MINOR), not bug fixes (PATCH).",
    "references": {
      "files": ["plugins/bootstrap/.claude-plugin/plugin.json"],
      "line_ranges": [[3, 3]],
      "related_tasks": ["task_001"]
    }
  },
  {
    "task_id": "task_005",
    "severity": "major",
    "category": "schema-validation",
    "message": "Plugin manifest missing required field 'author.name' in plugins/new-plugin/.claude-plugin/plugin.json",
    "suggestion": "Add 'author' object with 'name' field to plugin.json. Standard format: {\"name\": \"<author-name>\", \"email\": \"<optional>\"}, {\"url\": \"<optional>\"}",
    "references": {
      "files": ["plugins/new-plugin/.claude-plugin/plugin.json"],
      "line_ranges": [[1, 8]]
    }
  },
  {
    "task_id": "task_007",
    "severity": "minor",
    "category": "plugin-structure",
    "message": "Agent file 'test-agent.md' added to plugins/code/agents/ but not documented in CHANGELOG.md",
    "suggestion": "Add entry to CHANGELOG.md under 'Unreleased' section documenting new agent addition with brief description of purpose",
    "references": {
      "files": ["plugins/code/agents/test-agent.md", "CHANGELOG.md"],
      "related_tasks": ["task_003"]
    }
  }
]