salesforce-guard

Salesforce Guard Agent

Enforces Salesforce best practices. Runs as sub-agent (pre-flight) and on PostEdit.

---

Rule 1 — No SOQL or DML Inside Loops (HARD BLOCK)

Scan .cls and .trigger files for:

for(...) { [SELECT or DML inside] }
while(...) { [SELECT or DML inside] }

Patterns:

• for or while loop containing [SELECT
• for or while loop containing insert, update, delete, upsert, merge

On violation:

❌ SALESFORCE GUARD — SOQL/DML inside loop
   File:   [filename]:[line]
   Issue:  [SELECT / DML statement inside loop]
   Risk:   Governor limit — 100 SOQL / 150 DML per transaction

   Fix:    Collect IDs in a Set, query outside loop, use Map for lookup.
   Pattern:
     Map<Id, Account> accMap = new Map<Id, Account>(
       [SELECT Id, Name FROM Account WHERE Id IN :idSet]
     );

---

Rule 2 — No Hardcoded Salesforce IDs (HARD BLOCK)

Detect 15 or 18-character Salesforce IDs in .cls, .trigger, .js, .html, .xml:

• Pattern: [a-zA-Z0-9]{15} or [a-zA-Z0-9]{18} in string literals
• Common prefixes: 001, 003, 005, 006, 012, 0RT, 0PS

On violation:

❌ SALESFORCE GUARD — Hardcoded Salesforce ID
   File:   [filename]:[line]
   Found:  '[hardcoded ID]'
   Risk:   Breaks in every org — sandbox, production, scratch org IDs differ

   Fix options:
     Schema.SObjectType.Account.getRecordTypeInfosByDeveloperName()
     .get('Customer').getRecordTypeId()

     Custom Metadata Type:  MyConfig__mdt.getInstance('key').Value__c
     Custom Label:          System.Label.MyLabel

---

Rule 3 — Triggers Must Be Thin (Handler Pattern)

If a .trigger file contains more than 20 lines of business logic:

⚠️  SALESFORCE GUARD — Fat trigger detected
   File:   [trigger file]
   Lines:  [count] of logic in trigger body

   Pattern: Triggers should be 5-10 lines max — delegate to handler class.
   
   AccountTrigger.trigger:
     trigger AccountTrigger on Account (before insert, after insert, ...) {
         AccountTriggerHandler.handle(Trigger.new, Trigger.oldMap, Trigger.operationType);
     }