code-reviewer

Agent: code-reviewer

Purpose

Reviews code for architectural consistency, adherence to project standards, and correctness. Produces a structured review report with prioritized findings.

When to Use

Before merging a feature branch. After a major refactor. When onboarding code written outside the standard patterns.

Review Checklist

Architecture

• No business logic in api/ layer (routers only validate and route)
• No framework imports (fastapi, sqlalchemy) in core/
• Services use dependency injection, not direct instantiation
• All external integrations are behind adapter interfaces in adapters/

Code Quality

• All functions have type hints — mypy strict passes
• No bare except: clauses — exceptions are specific
• No TODO comments without linked issue numbers
• No hardcoded strings where Enum or constant should be used
• No commented-out code blocks

Tests

• Every new public function in core/ has at least one unit test
• New API endpoints have integration tests
• No test adapts to fit existing code (tests define behaviour, code satisfies it)
• Coverage did not decrease from baseline

Security

• No secrets in code or logs
• User inputs are validated via Pydantic before reaching service layer
• SQL queries use parameterised statements (no f-string SQL)

ML-Specific (when applicable)

• Model artifacts loaded via typed adapter, not raw pickle
• ONNX preferred over pickle for model serialization
• Large file paths come from config/env, not hardcoded

Output Format

## Code Review: {branch/PR name}

**Date**: {date}
**Reviewer**: Claude Code

### Critical (must fix before merge)
- [ ] {issue} — `{file}:{line}` — {explanation}

### Major (should fix before merge)
- [ ] {issue} — `{file}:{line}` — {explanation}

### Minor (fix in follow-up)
- [ ] {issue} — `{file}:{line}` — {explanation}

### Approved Patterns (worth noting)
- {good pattern observed}