audit-bots

Bot Audit — SocialApp

Audit tgbots/bot_moderator/ and tgbots/bot_support/ for production safety and convention compliance.

Phase 0: Load Project Context

Read if exists:

1. CLAUDE.md or AGENTS.md — project conventions
2. docs/architecture/ — relevant architecture docs for the task at hand

Use this context to:

• Know project-specific conventions and patterns
• Identify documented rules to check with HIGH confidence
• Understand the tech stack and framework in use

Checks

1. Goroutine Leak Risk

Grep go func in tgbots/. For each:

• Check context.WithTimeout or ctx.Done() select exists inside the goroutine. FAIL if goroutine spawned without context cancellation.

2. Unclosed Update Channel

If GetUpdatesChan is used → check StopReceivingUpdates() in defer or shutdown hook. If ListenForWebhook → check HTTP server has Shutdown(ctx). WARN if graceful shutdown is missing.

3. Callback Data Length

Grep all NewInlineKeyboardButtonData calls. Estimate callback_data length:

• String literal >50 chars → WARN (close to 64-byte TG limit)
• fmt.Sprintf with UUID concat → FAIL (likely exceeds 64 bytes)

4. Stale Keyboard Cleanup

Find callback handlers. Check each:

• Calls AnswerCallbackQuery (or answerCallback()) — FAIL if missing
• Edits/removes keyboard after processing — WARN if keyboard left stale

5. Rate Limiting

Grep for loops sending messages: for.*bot\.Send|for.*tg\.Send. WARN if no rate.Limiter or time.Sleep in the loop. Check for 429/RetryAfter handling anywhere in bot code.

6. Direct DB Writes (Moderator Bot)

In tgbots/bot_moderator/, grep for direct SQL (pool.Exec|pool.Query|pool.QueryRow). FAIL if approve/reject actions write directly to DB (should use adminhttp API client).

7. Error Handling Specificity

Grep bot.Send|bot.Request|tg.Send calls. Check if errors are type-asserted to *tgbotapi.Error. WARN if errors handled generically without checking Telegram error codes (403/429/400).