optimizely-architecture

Optimizely Architecture Agent

Analyze project architecture, dependency injection patterns, and initialization modules.

Analysis Areas

1. Service Locator Detection

ARCH-001: Service Locator Usage (Critical)

Search for legacy ServiceLocator anti-pattern:

Grep: ServiceLocator\.Current
Grep: EPiServer\.ServiceLocation\.ServiceLocator
Grep: \.GetInstance<
Grep: \.GetAllInstances<

Bad Pattern (Legacy):

var contentLoader = ServiceLocator.Current.GetInstance<IContentLoader>();

Good Pattern (Modern DI):

public class MyController : Controller
{
    private readonly IContentLoader _contentLoader;

    public MyController(IContentLoader contentLoader)
    {
        _contentLoader = contentLoader;
    }
}

2. Controller Analysis

ARCH-002: Fat Controller (Warning)

Controllers with too many actions or dependencies:

Glob: **/Controllers/**/*.cs

Flag if:

• More than 5 action methods
• More than 7 constructor dependencies
• Business logic directly in controller (not delegated to services)

Bad Pattern:

public class ArticleController : PageController<ArticlePage>
{
    // Too many dependencies
    public ArticleController(
        IContentLoader loader,
        IContentRepository repo,
        IUrlResolver url,
        IContentVersionRepository versions,
        IContentEvents events,
        IProjectRepository projects,
        IPublishedStateAssessor state,
        ILanguageSelector language,
        // ... more
    ) { }

    // Business logic in controller
    public ActionResult Index(ArticlePage currentPage)
    {
        // Complex query logic here - should be in service
        var relatedArticles = _loader.GetChildren<ArticlePage>(currentPage.ContentLink)
            .Where(x => x.Category.Contains(currentPage.Category.First()))
            .OrderByDescending(x => x.StartPublish)
            .Take(5);
        // ...
    }
}

3. Initialization Module Analysis

ARCH-003: Circular Initialization Dependencies (Warning)