ts-review

Perform comprehensive TypeScript code review:

1. Determine Review Scope

   • If $ARGUMENTS provided, review matching files
   • If in git repository, review changed files (git diff)
   • If reviewing PR, analyze all modified files
   • Otherwise, review recently modified files or current file

2. Static Analysis

   • Run TypeScript compiler: tsc --noEmit
   • Run ESLint: npm run lint or npx eslint
   • Check for type errors and warnings
   • Identify disabled linting rules

3. Type Safety Review

   Check for:

   • Usage of any without justification
   • Type assertions (as) that could be avoided
   • @ts-ignore comments (should be @ts-expect-error)
   • Missing return types on exported functions
   • Implicit any from missing annotations
   • Proper null/undefined handling
   • Type guards for runtime validation
   • Exhaustive checking of discriminated unions

4. Code Quality Review

   Naming & Readability:

   • Clear, descriptive names
   • Consistent naming conventions
   • Self-documenting code
   • Appropriate JSDoc for complex logic

   Structure:

   • Single responsibility per function
   • No code duplication
   • Proper separation of concerns
   • Logical organization

   Error Handling:

   • Errors properly caught and handled
   • Meaningful error messages
   • No swallowed exceptions
   • Custom error types for domain errors

5. TypeScript Best Practices

   Check for:

   • const over let where appropriate
   • readonly for immutable data
   • Optional chaining (?.) and nullish coalescing (??)
   • async/await over raw promises
   • Array methods over imperative loops
   • No Function, Object, Boolean, Number, String types
   • No enum foot-guns (prefer const objects)
   • Proper use of utility types (Partial, Pick, Omit, etc.)
   • satisfies operator for type validation (TS 4.9+)

6. Performance Analysis

   Look for:

   • Unnecessary re-renders (React)
   • Missing memoization for expensive operations
   • Inefficient algorithms (O(n²) loops)
   • Memory leaks (event listeners, subscriptions)
   • Type-system performance issues
   • Overly complex type computations

7. Security Review

   Check for:

   • SQL injection vulnerabilities
   • XSS vulnerabilities
   • Unsafe eval() usage
   • Credentials in code
   • Missing input validation
   • Type assertions bypassing security
   • any types in security-critical paths

8. Testing Coverage

   Verify:

   • Critical paths have tests
   • Edge cases covered
   • Tests are type-safe
   • No disabled/skipped tests without reason
   • Mocks properly typed

9. Generate Review Report

   Organize findings by priority:

   🔴 Blocking Issues (must fix before merge):

   • Security vulnerabilities
   • Type safety violations
   • Breaking changes
   • Critical bugs

   🟡 Important Issues (should address):

   • Type improvements
   • Performance concerns
   • Best practice violations
   • Missing tests

   🟢 Suggestions (nice to have):

   • Refactoring opportunities
   • Documentation improvements
   • Style consistency

   ✅ Positive Feedback:

   • Good practices observed
   • Well-structured code
   • Excellent type usage

10. Provide Actionable Feedback

    For each issue:

    • Show exact location (file:line)
    • Explain the problem clearly
    • Explain why it matters
    • Provide concrete fix with code example
    • Suggest alternatives if applicable

11. Summary

    Provide:

    • Overall code quality assessment
    • Count of issues by category
    • Estimated effort to address issues
    • Recommendation: Approve, Request Changes, or Comment
    • Next steps

Examples:

• /ts-review - Review changed files
• /ts-review src/ - Review directory
• /ts-review src/components/Button.tsx - Review specific file
• /ts-review --strict - Extra strict review

The review will be thorough, constructive, and educational, helping improve both the code and the developer's TypeScript skills.