review-module

Convention review for a SimpleModule module. Checks the module against the Constitution and project conventions.

If no module name was supplied as an argument, ask: "Which module would you like to review? (e.g. Products, Orders)"

Work through all 7 areas below in order. Do not auto-fix violations — record them and report at the end. For each violation found, record: file path, approximate line or pattern, what's wrong, how to fix it.

Replace {Name} with the module name throughout.

---

Area 1 — Architecture: No impl→impl dependencies

Read modules/{Name}/src/SimpleModule.{Name}/SimpleModule.{Name}.csproj.

For every <ProjectReference> path in that file, check whether the path points into another module's implementation assembly. A violation is a path that:

• Contains modules/ (or modules\)
• Does NOT end with .Contracts/SimpleModule.*.Contracts.csproj (or the backslash equivalent)

References to .Contracts projects are fine. References to the host or shared infrastructure are fine.

Violation fix: Replace the implementation reference with a reference to the other module's .Contracts project. Inject I{OtherModule}Contracts via constructor rather than using the concrete class directly.

---

Area 2 — Endpoints: CrudEndpoints helpers and TypedResults

Grep for MapGet|MapPost|MapPut|MapDelete in modules/{Name}/src/SimpleModule.{Name}/Endpoints/.

Check each match:

1. CrudEndpoints helpers — Standard CRUD operations should use CrudEndpoints.GetAll, CrudEndpoints.GetById, CrudEndpoints.Create, CrudEndpoints.Update, or CrudEndpoints.Delete rather than raw inline Results.* returns for the same operation. Flag any endpoint that manually reimplements what a CrudEndpoints helper already provides.

2. TypedResults — API endpoints must use TypedResults.* (e.g., TypedResults.Ok(...), TypedResults.NotFound()) not the non-generic Results.* static methods. Flag any use of Results.Ok, Results.NotFound, etc.