Archon: Command for Claude Code

Code Review: Pre-Commit Quality Check

Objective

Perform a thorough technical code review on recently changed files, checking for bugs, security issues, and adherence to Archon's documented conventions.

Process

1. Gather Codebase Context

Read the project conventions to understand what standards to enforce:

• Read AGENTS.md for project-wide conventions
• Read any relevant .claude/rules/ files for domain-specific patterns

2. Identify Changes to Review

git status
git diff HEAD
git diff --stat HEAD

Check for new untracked files:

git ls-files --others --exclude-standard

Read each new file in its entirety. Read each changed file in its entirety (not just the diff) to understand full context.

3. Review Checklist

For each changed or new file, analyze for:

Logic Errors

• Off-by-one errors, incorrect conditionals
• Missing error handling or silent failures
• Race conditions (especially in async/streaming code)
• Incorrect TypeScript type narrowing

Security Issues

• SQL injection in raw queries
• XSS in rendered content
• Exposed secrets or API keys
• Insecure data handling

Performance Problems

• N+1 database queries
• Missing cleanup (event listeners, intervals, AbortControllers)
• Unnecessary re-renders in React components
• Unbounded array growth

Type Safety

• Use of any without justification
• Missing type annotations on functions
• Incorrect type assertions (as casts)
• Overly broad types where narrow types exist

Archon-Specific Conventions

• Import patterns: import type for type-only imports, no import * as core
• Use execFileAsync not exec for git operations
• Never git clean -fd
• Structured Pino logging with {domain}.{action}_{state} event naming
• bun run test not bun test from repo root
• mock.module() isolation (separate test batches for conflicting mocks)
• Lint passes with zero warnings (bun run lint)

Package Boundary Compliance

• No circular dependencies between packages
• @archon/git and @archon/paths must not import from @archon/core
• @archon/workflows injects deps via narrow interfaces, not direct core imports