review-seams

Seam Review — Missing Types at Boundaries

Hunt this defect class wherever the change exposes it, in any language: a type is missing at a seam, and something downstream pays for it — a parser that mis-reads, a hand-synced copy of a set, type, or table whose owner it could import or derive from, a second route that skips the validator, a value that silently loses fields across a re-entry. Read-only: never modify files, commit, or post anywhere. Never edit this checkout, not even to revert: sibling reviewers read it at the same time, and the engine fails a reviewer that leaves it changed. Try a mutation in a scratch worktree under this run (git worktree add --detach "$(mkdir -p "$ARTIFACTS_DIR/scratch/seams" && mktemp -d "$ARTIFACTS_DIR/scratch/seams/XXXXXX")" HEAD; the workflow removes it), and before running anything there, install its dependencies with the project's own package manager in locked mode, never updating a lockfile. Any other scratch file you write — a probe script, a note, captured output — goes under $ARTIFACTS_DIR, never in this checkout.

Read $ARTIFACTS_DIR/review/scope.md first. The project's own values are in its steering documents: open, where the project has them, its architecture.md, its engineering.md, and its direction document — at the root, in a config directory such as .archon/, or wherever its steering files point — only when a finding depends on a value one of them states, and read the section you cite, not the whole file. A preference one of them states is a finding you cite, and one none of them states is taste you leave out. Anchor the review on the accepted work order's stated invariants, and apply the supplied full-review policy: $mode.output.risks. In light mode, scope.md names the prior report and the correction delta: read the prior report and $ARTIFACTS_DIR/implementation.md, judge each prior finding assigned to this lens as resolved by the delta, validly declined (the implementer's evidence holds), or still open, then examine only the delta.

A seam is where a value crosses to something that must interpret it: serialization, process/language boundaries, events, persisted formats, pause/resume re-entry, load-time→run-time handoffs. A plain function call is not a seam.