gx-review-di

Review Galaxy Code for Dependency Injection Best Practices

Perform a Python code review on the provided code. Accept input in any of the following forms:

1. A working directory path (analyze git diff in that directory)
2. A Git commit reference (analyze changes in that commit)
3. A list of Python file paths (analyze those files)
4. A planning document (analyze the Python files in the plan)

Review Criteria

Review the code and ensure it follows best practices for dependency injection in Galaxy:

1. Avoid FastAPI-style injection - Prefer Galaxy-style DI using Lagom and type-based injection
2. Proper service/manager layer dependencies - Dependencies should be injected via constructors, not via app access
3. Avoid app property creation - Don't add new properties to the app object when DI can be used

Galaxy DI Architecture Background

The Problem: God Object Anti-pattern

Galaxy's app object was historically a "god object" - an object that knows/does too much. Every component, controller, and web transaction had a reference to app. This creates:

• Circular dependencies (manager imports UniverseApplication, which creates that manager)
• Difficult testing (hard to know what parts of app are needed, hard to mock)
• Brittle construction ordering

The Solution: Type-based Dependency Injection

Galaxy uses Lagom for type-based DI:

• Container keeps track of singletons and construction recipes
• Dependencies are resolved automatically based on type annotations
• Dependencies should form a DAG (directed acyclic graph)

Interface Pattern for Breaking Cycles

Use StructuredApp interface instead of UniverseApplication to break circular dependencies:

# BAD - creates circular dependency
class MyManager:
    def __init__(self, app: UniverseApplication):
        ...

# GOOD - uses interface, breaks cycle
class MyManager:
    def __init__(self, app: StructuredApp):
        ...

# BETTER - inject only what you need
class MyManager:
    def __init__(self, model: GalaxyModelMapping, security: IdEncodingHelper):
        ...