golang-development:review

Golang Development Review Command

Comprehensive Go code review focusing on idiomatic patterns, performance, security, and best practices.

Usage

/golang-development:review [file-path-or-directory] [focus-area]

Arguments

• $1 - File path or directory to review (optional, defaults to current directory)
• $2 - Focus area: all, idioms, performance, security, concurrency, errors (optional, defaults to all)

Examples

# Review all files in current directory
/golang-development:review

# Review specific file
/golang-development:review internal/service/user.go

# Focus on performance issues
/golang-development:review . performance

# Focus on security
/golang-development:review ./handlers security

# Review concurrency patterns
/golang-development:review . concurrency

Review Categories

1. Idiomatic Go (idioms)

Checks:

• Naming conventions (camelCase, capitalization)
• Error handling patterns
• Interface usage and design
• Struct composition over inheritance
• Receiver naming and types
• Exported vs. unexported identifiers
• Go proverbs adherence

Example Issues:

// ❌ BAD: Non-idiomatic error handling
func getUser(id string) (*User, string) {
    if id == "" {
        return nil, "invalid ID"
    }
    // ...
}

// ✅ GOOD: Idiomatic error handling
func GetUser(id string) (*User, error) {
    if id == "" {
        return nil, fmt.Errorf("invalid ID: %s", id)
    }
    // ...
}

// ❌ BAD: Getter naming
func (u *User) GetName() string {
    return u.name
}

// ✅ GOOD: Idiomatic getter
func (u *User) Name() string {
    return u.name
}

// ❌ BAD: Setter without validation
func (u *User) SetAge(age int) {
    u.age = age
}

// ✅ GOOD: Validated setter with error
func (u *User) SetAge(age int) error {
    if age < 0 || age > 150 {
        return fmt.Errorf("invalid age: %d", age)
    }
    u.age = age
    return nil
}

2. Performance (performance)

Checks:

• Unnecessary allocations
• String concatenation in loops
• Slice pre-allocation
• Map pre-allocation
• Defer in loops
• Inefficient algorithms
• Memory leaks
• Goroutine leaks