ui-aqa-flow-test-correction

<ui_aqa_flow_test_correction>

<description_and_purpose> Fix identified test failures based on the Phase 7 failure analysis. Prepares proposed changes, requires explicit user approval before applying, then applies them incrementally with lint checks and hands re-testing back to the user. </description_and_purpose>

<workflow_context>

• Phase 8 of 8 in ui-aqa-flow
• Input: failure analysis from Phase 7 (plans/ui-aqa-<test-name>/failure-analysis.md)
• Output: corrected test code, ready for re-testing
• Prerequisite: Phase 7 complete
• HITL: explicit user approval required before applying any change (a domain-specific specialization of hitl)
• In-scope file set (single SSoT): test files only (and page-object files if the Phase 7 analysis identifies a selector fix). Writes outside this set are refused and escalated.
• Required skills: qa-knowledge (correction mode — proposed-change block + approval gate + correction discipline), qa-structure (run paths + state)
• Recommended skills: coding (authors the proposed/applied edits), debugging (root-cause alignment), hitl (explicit approval) </workflow_context>

<correction_contract> The phase OWNS the iteration cap and the escalation contract. The proposed-change approval block is qa-knowledge's shared proposed-change template (the skill loads its own asset at step 8.1) — present one block per change BEFORE any write. Flow parameters for the template: change-type enum = selector-update | wait-strategy | assertion-fix | data-setup | other; root-cause reference = Phase 7 failure-analysis entry id (e.g. F3); state file = agents/TEMP/<FEATURE>/ui-aqa-state.md; on retry-cap, loop back to Phase 7. Verified by <validation_checklist> independent of skill internals. </correction_contract>

<phase_steps>

1. Prepare proposed corrections (step 8.1 — preparation-only)
2. Present changes for approval (step 8.2)
3. Apply approved changes (step 8.3)
4. Update state (step 8.4) </phase_steps>

<execute_corrections step="8.1" subagent="engineer" role="Test correction engineer"> Guardrail: all of step 8.1 is preparation-only; file writes are forbidden until step 8.3. "Preparation-only" means proposed edits paired with before/after evidence — no writes to test, page-object, or product source files.

1. USE SKILL qa-structure to resolve run paths/state. USE SKILL debugging to align each proposed edit with a confirmed Phase 7 root cause (no symptom-only fixes).
2. USE SKILL qa-knowledge (correction mode) and USE SKILL coding to author each proposed edit (preparation-only — before/after evidence, no writes). The present → approve → apply discipline is owned by this phase: <present_for_approval> (8.2) + <apply_changes> (8.3). Bindings: proposed-change source = plans/ui-aqa-<test-name>/failure-analysis.md; proposed-change template = <correction_contract>; in-scope file set = <workflow_context>; approval-token set = step 8.2; state file = agents/TEMP/<FEATURE>/ui-aqa-state.md; iteration cap = <correction_contract>; loop target = Phase 7.
3. Produce one Proposed Change record per fix per the <correction_contract> template. Do NOT apply anything yet. </execute_corrections>

<present_for_approval step="8.2">

1. Present all proposed changes with before/after code per the template.
2. Approval gate: USE SKILL qa-knowledge to run its shared approval gate; USE SKILL hitl. Approval = an exact token from the closed list approved / approve / yes (case-insensitive), scoped to the named changes — no "or equivalent" / "or similar" phrasing extends it. Comments, questions, suggestions, edits, and partial review are REVIEW, not approval. Partial approval applies only to named changes/hunks; re-present changed proposals; full rejection returns to Phase 7. </present_for_approval>

<apply_changes step="8.3">

1. Apply approved changes one at a time (or in named approved batches).
2. Validate linting/format after each change. On lint failure: revert that change (never leave the file broken), re-prepare, and re-present that single change via <present_for_approval>.
3. Verify each applied change addresses its Phase 7 root cause (cite the analysis entry id). On root-cause mismatch: return to step 8.1 with a note in agents/TEMP/<FEATURE>/ui-aqa-state.md; do not leave unmapped changes applied.
4. Max retries: apply the <correction_contract> iteration cap — on the 3rd failed cycle for the same change, stop, record Phase 8 blocked: in-phase apply retry cap reached in ui-aqa-state.md, loop back to Phase 7 (do not auto-start a 4th cycle). </apply_changes>