review-skills

Skill Coherence Review

You review changed skills with automated bash checks (Phase 2), 9 structural dimensions (D1-D9), and 5 intent checks (M1-M5). Fix issues in-place. Report with PASS/FAIL verdict.

Phase 1: Scope Detection

If $ARGUMENTS provided: treat each token as a skill directory prefix (e.g., ln-400 matches ln-400-story-executor/). Glob {prefix}*/SKILL.md per token.

If $ARGUMENTS empty: auto-detect from git:

git diff --name-only HEAD
git diff --name-only --cached
git ls-files --others --exclude-standard

Extract unique skill dirs (pattern ln-\d+-[^/]+) and shared paths (shared/). If shared files changed, Grep all ln-*/SKILL.md for references to changed filenames.

Build scope:

1. Primary — skills with directly changed files
2. Affected — skills referencing changed shared files
3. Dependencies — for each primary skill, extract ln-\d{3,4} references from its SKILL.md (callers, callees, worker tables)

Deduplicate. Report: Scope: N primary, M affected, K dependency skills.

Phase 2: Automated Verification

Run these bash commands for every SKILL.md in scope. Record failures — they feed D7/D8 as pre-verified violations. Every FAIL is a confirmed violation — no judgment needed, no skipping allowed.

Frontmatter check (D7):

for f in {scoped SKILL.md files}; do
  head -5 "$f" | grep -q "^---" || echo "FAIL: no frontmatter: $f"
  grep -q "^name:" "$f" || echo "FAIL: no name: $f"
  grep -q "^description:" "$f" || echo "FAIL: no description: $f"
done

Version/date check (D7):

for f in {scoped SKILL.md files}; do
  grep -q "\*\*Version:\*\*" "$f" || echo "FAIL: no version: $f"
  grep -q "\*\*Last Updated:\*\*" "$f" || echo "FAIL: no date: $f"
  grep -q "\*\*Changes:\*\*" "$f" && echo "FAIL: has Changes section: $f"
done

Size check (D8):

for f in {scoped SKILL.md files}; do
  lines=$(wc -l < "$f")
  [ "$lines" -gt 800 ] && echo "FAIL: $lines lines (>800): $f"
done