pr-review-merge

PR Review Before Merge: $ARGUMENTS

Comprehensive pre-merge review to validate code quality, security, best practices, and readiness for production.

Phase 1: PR Metadata Analysis

# Get PR details
!gh pr view $ARGUMENTS --json title,body,author,reviewers,state,isDraft,mergeable,statusCheckRollup,headRefName,baseRefName

# Check review status
!gh pr reviews $ARGUMENTS

Initial Validation Checklist

• PR is not in draft status
• PR has proper title and description
• No merge conflicts
• CI/CD checks are passing
• Required approvals are present
• Target branch is correct (usually main/master)

BLOCKER: If any critical items fail, stop and report issues before continuing.

Phase 2: Changed Files Analysis

# Get PR diff
!gh pr diff $ARGUMENTS

# List changed files with stats
!gh pr view $ARGUMENTS --json files

File-Level Checks

Size Validation (per project 500-line limit):

# Check for oversized files
!gh pr diff $ARGUMENTS --name-only | while read file; do
    lines=$(git show HEAD:"$file" 2>/dev/null | wc -l)
    if [ "$lines" -gt 500 ]; then
        echo "⚠️  WARNING: $file has $lines lines (limit: 500)"
    fi
done

Modular Design:

• Each file should have single responsibility
• Check for proper separation of concerns
• Verify clean interfaces between modules

Phase 3: Code Quality Review

# Run comprehensive quality checks
!echo "🔍 Running code quality analysis..."

Language-Specific Quality Checks

Python Projects:

# Formatting
!if command -v black &> /dev/null; then echo "→ Formatting (black):" && black --check . 2>&1 | head -20; fi

# Linting
!if command -v flake8 &> /dev/null; then echo "→ Linting (flake8):" && flake8 src/ tests/ 2>&1 | head -20; fi

# Type checking
!if command -v mypy &> /dev/null; then echo "→ Type checking (mypy):" && mypy src/ 2>&1 | head -20; fi

# Test coverage
!if command -v pytest &> /dev/null; then echo "→ Test coverage:" && pytest --cov=src --cov-report=term-missing 2>&1 | tail -10; fi