check-data-layer

Check Data Layer Violations

Scan the codebase for violations of the data layer separation architecture and report them.

What to Check

1. Component violations:

• Search for import.*createClient.*from.*@/lib/supabase/client in component files
• Search for useQuery or useMutation defined directly in component files (not imported)

2. Hook violations:

• Search for createClient() calls in /hooks/ files
• Hooks should only import service functions, not call Supabase directly

3. Service organization:

• Check if service functions are properly organized in /lib/services/
• Verify proper file naming: {table-name}.ts or {feature-name}-service.ts

4. TypeScript violations:

• Functions without explicit return types
• Async functions without Promise<T> return types
• Inline type definitions (not imported from /types/)
• Usage of any type
• Duplicate type definitions that already exist in /types/

Search Patterns

Use Grep to find violations:

# === Architecture Violations ===

# Find components importing Supabase client
grep -r "import.*createClient.*from.*@/lib/supabase/client" app/ components/ --include="*.tsx" --include="*.ts"

# Find inline queries in components (check for useQuery not from import)
grep -r "useQuery({" app/ components/ --include="*.tsx" -A 3

# Find createClient in hooks (should be in services only)
grep -r "createClient()" hooks/ --include="*.ts" --include="*.tsx"

# Find service functions not in /lib/services/
grep -r "from('.*')" app/ components/ hooks/ --include="*.tsx" --include="*.ts"

# === TypeScript Violations ===

# Find functions without return types (async functions)
grep -rE "export async function [a-zA-Z]+\([^)]*\)\s*{" lib/services/ hooks/ --include="*.ts" --include="*.tsx"

# Find functions without return types (regular functions)
grep -rE "export function [a-zA-Z]+\([^)]*\)\s*{" lib/services/ hooks/ --include="*.ts" --include="*.tsx"

# Find usage of 'any' type
grep -r ": any" lib/services/ hooks/ --include="*.ts" --include="*.tsx"

# Find inline type definitions (type/interface not in /types/)
grep -r "^type [A-Z]" app/ components/ lib/services/ hooks/ --include="*.ts" --include="*.tsx"
grep -r "^interface [A-Z]" app/ components/ lib/services/ hooks/ --include="*.ts" --include="*.tsx"