address

Address Review Feedback for PR #$ARGUMENTS

Systematic feedback resolution. Follows Explore > Plan > Code > Verify loop.

Required Skills

• llm-operator-principles — foundational operator stance: convergence = zero findings, in-PR fixes by default, no calendar-time estimates, narrow escalation triggers. MUST be consulted before any other phase
• feedback-resolution — surgical changes, context recovery, pushback criteria
• change-classification — verify no out-of-context changes
• capability-discovery — quality commands for verification
• tdd-patterns — test-first for fixes, test quality standards
• holdout-validation — cross-reference self-review claims against file state (Phase 4)

References

• references/escalation-format.md — canonical six-field structure used by Phase 3's out-of-scope-finding escalation, Phase 4's review-cycle-limit escalation, and any Proactive-Autonomy escalation surfaced during feedback resolution
• references/finding-schema.md — canonical row shape every reviewer agent dispatched in the Phase 4 re-review fan-out emits

Phase 1: EXPLORE

gh pr checkout stays inline (mutating); read-only context-gathering is in the ! block below.

# Take the first whitespace-separated token; accept only if it is all digits.
# A non-numeric token (e.g., "foo42" or "evil;rm") is rejected with empty
# PR_NUM so it never reaches the prompt context or any downstream shell.
#
# Output: `###`-headed sections + KEY=value per
# `references/command-output-format.md`. STATE=blocked on bad input.
_RAW="$ARGUMENTS"  # Claude Code substitutes the bare arg token, not bash parameter-expansion
ARG1="${_RAW%% *}"
case "$ARG1" in
  ''|*[!0-9]*) PR_NUM="" ;;
  *) PR_NUM="$ARG1" ;;
esac

echo "### PR Reference"
if [ -z "$PR_NUM" ]; then
  echo "STATE=blocked"
  echo "ERROR=PR number required (all-digit). Usage: /flow:address <pr-number>"
else
  echo "STATE=ok"
  echo "PR_NUM=$PR_NUM"

  # Section: PR Details
  echo ""
  echo "### PR Details"
  gh pr view "$PR_NUM" --json headRefName,baseRefName,title,body --jq '
    "TITLE=\"\(.title)\"\nHEAD_BRANCH=\(.headRefName)\nBASE_BRANCH=\(.baseRefName)\nBODY_LENGTH=\(.body | length)"
  ' 2>/dev/null

  # Section: Inline Review Comments
  echo ""
  echo "### Inline Review Comments"
  REPO=$(gh repo view --json nameWithOwner --jq '.nameWithOwner' 2>/dev/null)
  # Capture gh exit separately. gh failure ⇒ "" + non-zero exit; jq on empty
  # stdin produces no output + exit 0, so `|| echo "0"` doesn't fire and the
  # block silently emits a bare `INLINE_COUNT=` line. Distinguish unavailable
  # (gh failed) from empty (gh ok, no records).
  INLINE_JSON=$(gh api "repos/$REPO/pulls/$PR_NUM/comments" 2>/dev/null); GH_EXIT=$?
  if [ $GH_EXIT -ne 0 ]; then
    echo "INLINE_COUNT=0"
    echo "STATE=unavailable"
    INLINE_JSON="[]"  # neutral fallback so the Conversation Threads section below also degrades gracefully
  else
    INLINE_COUNT=$(echo "$INLINE_JSON" | jq 'length' 2>/dev/null)
    [ -z "$INLINE_COUNT" ] && INLINE_COUNT=0
    echo "INLINE_COUNT=$INLINE_COUNT"
    if [ "$INLINE_COUNT" = "0" ]; then
      echo "STATE=empty"
    else
      # One record per comment; full body lives in the JSON cache for the agent
      # to fetch on demand. The summary line carries the routing fields.
      echo "$INLINE_JSON" | jq -r '.[] | "INLINE_COMMENT=id=\(.id) author=@\(.user.login) path=\(.path) line=\(.line // "?") length=\(.body | length)"' 2>/dev/null
    fi
  fi

  # Section: Review Summaries
  echo ""
  echo "### Review Summaries"
  REVIEWS_JSON=$(gh pr view "$PR_NUM" --json reviews --jq '.reviews' 2>/dev/null); GH_EXIT=$?
  if [ $GH_EXIT -ne 0 ]; then
    echo "REVIEW_COUNT=0"
    echo "STATE=unavailable"
  else
    REVIEW_COUNT=$(echo "$REVIEWS_JSON" | jq 'length' 2>/dev/null)
    [ -z "$REVIEW_COUNT" ] && REVIEW_COUNT=0
    echo "REVIEW_COUNT=$REVIEW_COUNT"
    if [ "$REVIEW_COUNT" = "0" ]; then
      echo "STATE=empty"
    else
      echo "$REVIEWS_JSON" | jq -r '.[] | "REVIEW=state=\(.state) author=@\(.author.login) at=\(.submittedAt) length=\(.body | length)"' 2>/dev/null
    fi
  fi

  # Section: Conversation Threads (grouped by file path)
  echo ""
  echo "### Conversation Threads"
  THREADS=$(echo "$INLINE_JSON" | jq -r 'group_by(.path) | .[] | "THREAD=file=\(.[0].path) count=\(length)"' 2>/dev/null)
  if [ -z "$THREADS" ]; then
    echo "STATE=empty"
  else
    echo "$THREADS"
  fi
fi

true