agentic-playwright refactor-values.instructions.md

Refactoring Enum Values and Static Test Data

Critical

• ALWAYS run Phase 1 (find all consumers) before making any edit. Enum values and static data feed into tests, page objects, schemas, and assertions — the blast radius must be known up front.
• ALWAYS search for both the enum key (Messages.LOGIN_ERROR) and the raw string value ('Invalid email or password'). Some consumers may have bypassed the enum and hardcoded the string — they won't update when you change the enum.
• NEVER update an enum value, rename a key, or edit a static-data file without updating every consumer in the same commit (atomicity — no intermediate broken state).
• NEVER loosen a Zod schema (z.literal / z.enum) to make an updated value pass. Update the schema to match the new value; the schema is the contract.
• ALWAYS run npx tsc --noEmit + npx eslint . + the affected tests before concluding the refactor. TypeScript catches key renames; eslint catches stale patterns; tests catch assertion drift.
• NEVER use a single global find-and-replace — it misses case variants, hardcoded copies, and references inside comments, documentation, and sibling skill files. Inspect each match.

Instructions

Phase 1: Find all consumers before touching anything

Search the entire codebase for every occurrence of both:

1. The enum key (the import reference consumers use).
2. The current string value (the raw string — catches hardcoded usages that bypass the enum).

Use rg (ripgrep) when available — faster and more ergonomic — or grep -r as a universal fallback:

# Find all usages of the enum key
rg "Messages.LOGIN_ERROR" .
grep -r "Messages.LOGIN_ERROR" .

# Find all usages of the raw string value
rg "Invalid email or password" .
grep -r "Invalid email or password" .

# For endpoint changes, search both
rg "ApiEndpoints.LOGIN" .
rg "'/api/users/login'" .

Do this before making any edits. Understand the full blast radius first. Expect matches in .ts, .tsx, .md (instruction files, README, CHANGELOG), and .json (Playwright reports — ignore).