qml4j CLAUDE.md

qml4j — house rules

Imports

• Never use a fully-qualified class name inline. Always add an import at the top of the file. This includes Java types (java.util.List), generated classes, our own modules, and one-off references in test code.
• The only exception is when two classes share a simple name and one must stay short — in that case, import one and FQN the other with a comment explaining the clash.
• Don't write io.qml4j.engine.binding.DirtyQueue dq = ...; write import io.qml4j.engine.binding.DirtyQueue; then DirtyQueue dq = ....
• Same rule for tests. Don't assertEquals with io.qml4j.render.items.NumberAnimation inline — import it.

Class & method size

Aim for small, single-purpose units. If a method or class is doing several distinct things, extract.

• Methods — one job. If you can't describe what a method does in one short clause without "and", split it. Prefer extracting a private helper over inlining a 30-line block.
• Classes — one concept. If a class accumulates unrelated state (e.g. Item holding rendering geometry AND state-machine orchestration AND animation pooling), pull the orchestration into its own type and inject/compose. Item holds geometry; a StateController or similar holds the state pipeline.
• Constructors that wire listeners, build maps, and configure children should hand most of that work to private methods or factories. Keep <init> short.
• God methods are forbidden. If applyState does diff-compute, revert, apply, snapshot, spawn animations — that's five jobs. Each gets a method.

When refactoring an existing fat class as part of new work, do the extraction in the same change. Don't pile on.

Dispatch & polymorphism

The RECODE refactor replaced the engine's instanceof/switch type-dispatch with polymorphism. Keep it that way.

• Never dispatch on an item or AST-member type with instanceof/switch. Behavior that varies per type lives on the type. Drawable items override Item.paint(Painter); items with intrinsic size override Item.measure(TextLayout); layout containers override Item.layout() — the Renderer just walks the tree and calls the hook (double-dispatch, not a per-type branch). New compiled member kinds get a MemberEmitter registered in QmlCompiler.memberEmitters keyed on the member class, not a new if (m instanceof ...) arm.
• Items never import skija. Drawing goes through Painter primitives (the one exception is Image.skiaImage, a field). Font-heavy/complex draws are a Painter.drawXxx(item, ...) primitive the item delegates to; simple geometry keeps its logic in the item and calls low-level Painter ops.
• Thread shared emit/render state as a parameter object, not a long argument list. EmitContext bundles the per-object-body emit state; don't re-introduce 14-parameter signatures.
• Compose collaborators via constructor injection; keep the public type a facade. QmlView owns nothing but delegation — Loader (compile+instantiate), FocusManager (focus/tab), EventDispatcher (pointer/key/text/clipboard) do the work and are injected. The Renderer's FontResolver/IconResolver/TextLayout are injected the same way. Add a responsibility as a new injected collaborator, not as more state on the facade.
• switch is fine for value mapping, not type dispatch. Legitimate and kept: parser token dispatch (the ANTLR visitor), bytecode emission (typeName→opcode, lit.kind), value/ordinal/string→value maps (keycode→Signal, wrapMode→string, line.edge, plan.op, hex.length(), QColor channel), and pure stateless framework math tables (Easings). These are not the antipattern; don't "polymorphize" them into ceremony.