code-optimization

Code Optimization Guidelines

🎯 Core Principles

1. DRY (Don't Repeat Yourself)

• Eliminate code duplication across files and functions
• Extract shared logic into reusable functions/classes
• Centralize constants and configuration
• Use composition over duplication

2. Single Responsibility Principle

• One function = One purpose
• Separate concerns clearly (validation, processing, I/O)
• Avoid functions that do too much
• Group related functionality logically

🔍 Identifying Problems

Red Flags to Watch For:

• Duplicate constants across multiple files
• Similar function logic in different modules
• Functions with multiple responsibilities
• Artificial function boundaries that don't add value
• Mixed abstraction levels in the same function
• Redundant parameter processing

🛠️ Optimization Strategies

1. Function Consolidation

# ❌ BAD: Two functions doing similar things
def invoke_mtproto_method(method, params, params_json=""):
    # Does preprocessing + Telethon interaction
    
def invoke_mtproto_impl(method, params_json, allow_dangerous=False):
    # Does preprocessing + calls invoke_mtproto_method

# ✅ GOOD: Single function with clear purpose
def invoke_mtproto_impl(method, params_json, allow_dangerous=False, resolve=True):
    # Does everything in one logical flow

2. Constant Extraction

# ❌ BAD: Duplicate constants across files
# In file1.py
DANGEROUS_METHODS = {"messages.DeleteMessages", ...}

# In file2.py  
DANGEROUS_METHODS = {"messages.DeleteMessages", ...}

# ✅ GOOD: Centralized constants
# In constants.py
DANGEROUS_METHODS = {
    "account.DeleteAccount",
    "messages.DeleteHistory",
    "messages.DeleteMessages",
    # ...
}

3. Helper Function Extraction

# ❌ BAD: Logic scattered in main function
def main_function():
    # 50 lines of mixed logic
    if "." not in method_name:
        raise ValueError("Invalid format")
    module_name, class_name = method_name.rsplit(".", 1)
    # ... more mixed logic

# ✅ GOOD: Clear separation with helpers
def _resolve_method_class(method_name):
    """Resolve method name to Telethon class"""
    if "." not in method_name:
        raise ValueError("Invalid format")
    # ... focused logic

def main_function():
    method_cls = _resolve_method_class(method_name)
    # ... clean main logic