12-code-review-checklist

12-code-review-checklist is a cursor rule for coding agents from movebrickschi/harness-engineering-mcp. It costs 470 tokens per session, scanned A, original, MIT.

A code-review checklist and technical-debt guide. Technical debt means short-term code decisions that create cleanup work later.

In plain words
What is it for?
Use it while creating or reviewing code, recording temporary workarounds, marking deprecated code, and documenting major technical decisions in an architecture decision record.
Why use it?
It helps catch architecture problems, concurrency bugs, resource leaks, performance issues, security flaws, and maintainability problems before they spread.

Cursor rule

Install

Getting it into your agent

One page per mod, every tool's command on it. A separate URL per tool would split the same page into five that compete with each other.

agentmods
npx agentmods add rules/movebrickschi/harness-engineering-mcp/12-code-review-checklist
Clone the repo
git clone --depth 1 https://github.com/movebrickschi/harness-engineering-mcp

Wrote this? Show the measurements

A badge with what this costs and how it scanned, read live from this page, so it follows the numbers instead of freezing them. Markdown for a README, HTML for a documentation site or a project page.

agentmods badge for 12-code-review-checklist

README.md
[![agentmods](https://agentmods.dev/badge/rules/movebrickschi/harness-engineering-mcp/12-code-review-checklist.svg)](https://agentmods.dev/rules/movebrickschi/harness-engineering-mcp/12-code-review-checklist)
Your own site
<a href="https://agentmods.dev/rules/movebrickschi/harness-engineering-mcp/12-code-review-checklist"><img src="https://agentmods.dev/badge/rules/movebrickschi/harness-engineering-mcp/12-code-review-checklist.svg" alt="Measured on agentmods" height="20"></a>
Per session 470 This file is loaded in full into every session.
When invoked 470 The same file — it is already loaded in full.
Security scan A 0 findings. Scan, not verified.
Origin original No closer match found in the catalogue.
Token cost

What it costs to keep this loaded

Counted locally with the o200k_base tokenizer, which is exact for GPT models; Claude uses its own tokenizer and its counts differ. Treat this as one consistent yardstick across the catalogue rather than a bill. Prices are per million input tokens.

ModelPer sessionOnce invoked
Fable 5 $0.00470 $0.00470
Opus 5 $0.00235 $0.00235
Sonnet 5 $0.00094 $0.00094
Haiku 4.5 $0.00047 $0.00047

Measured 3d ago against content hash 0f749ccf09ba, method: parsed. Prices are Anthropic first-party input rates as of 2026-08-30, from the pricing page.

Security

Grade A, and why

12-code-review-checklist scanned grade A with 0 findings against 26 rules in 11 categories — prompt injection, anti-refusal, data exfiltration, privilege escalation, supply chain, agent snooping, system-prompt leakage, SSRF and excessive agency — measured 3d ago.

A static scan of the body, not an audit. Every finding is printed with the line that produced it so you can judge whether it matters here. A mod is markdown that instructs an agent; that is exactly why what it instructs is worth reading.

Nothing flagged

None of the 26 patterns this scan looks for appear in this file: no shell pipes, no recursive deletes, no credential paths, no hidden text, no instruction-override or anti-refusal phrasing, no agent-config snooping. That is not a guarantee, it is the absence of the things that are checkable.

assets/rules/12-code-review-checklist.mdc · 51 lines

What it actually says

代码审查清单与技术债管理

生成代码前自检清单

每次生成或修改代码时,必须逐项检查:

  • 架构违规:是否违反分层原则,Domain层是否出现Repository直接调用
  • 并发陷阱:是否存在race condition,volatile使用是否正确,锁粒度是否过大
  • 资源泄漏:Stream是否关闭,数据库连接是否归还,ThreadPool是否shutdown
  • 性能隐患:大循环中是否创建对象,是否存在O(n²)算法,SQL是否走索引
  • 安全漏洞:输入是否验证,输出是否转义,权限是否校验
  • 可维护性:魔法数字是否提取为常量,复杂表达式是否提取为语义化方法

技术债管理

TODO标记格式

临时方案必须标记,格式如下:

// TODO: TECH-DEBT-2026-001 原因:当前使用硬编码阈值 计划解决时间:Q3
private static final int MAX_RETRY = 3;

废弃代码

@Deprecated注解必须说明替代方案和移除版本:

/**
 * @deprecated 请使用 {@link UserServiceV2#findById},将在 v3.0 移除
 */
@Deprecated(since = "2.5", forRemoval = true)
public User getUser(Long id) { }

架构决策记录(ADR)

新增技术组件必须创建 .harness/adr/NNNN-决策标题.md,包含:

  • 上下文(Context):为什么需要这个决策
  • 决策(Decision):选择了什么方案
  • 后果(Consequences):带来的影响和代价
  • 拒绝的替代方案:其他方案及其被拒绝的理由
Changes

What this file has done since we first saw it

Hashed on every crawl. A supply-chain change to an agent config is a question of when, not whether, so the history is kept rather than the latest state alone.

  1. 3d ago First seen · 51 lines · 470 tokens per session scan A 0f749ccf09ba

Subscribe to this mod's changes

12-code-review-checklist is a cursor rule published in the GitHub repository movebrickschi/harness-engineering-mcp (2 stars, last pushed 3mo ago), licensed MIT. It adds 470 tokens to every session, about $0.0024 per session on Opus 5. A static security scan graded it A with 0 findings. No closer match exists in the catalogue, so it is treated as the original; first seen 2026-08-31.