15-100-go-mistakes

Curated ROSA Adaptation Of 100 Go Mistakes

This is a supplemental checklist. AGENTS.md and 10-go-cobra-cli.mdc remain the primary ROSA guidance. It is intentionally shorter than broader Terraform-oriented variants: keep only the footguns that reinforce ROSA CLI patterns without duplicating the repo-specific command, AWS, and testing rules above.

• Avoid variable shadowing, especially err, ctx, and AWS or OCM clients.
• Do not define interfaces too early. Prefer consumer-side interfaces and return concrete types unless the codebase already establishes an interface boundary.
• Wrap returned errors with context using %w; do not drop the original error.
• Do not store context.Context in structs.
• Be explicit about nil versus empty slices only when behavior truly depends on it.
• Avoid magic numbers; extract named constants when the value matters to behavior or readability.
• Do not rely on map iteration order or goroutine scheduling in tests or production logic.
• Avoid init() except where registration patterns truly require it.
• Keep goroutines bounded and cancelable. Do not leak them during polling, retries, or test helpers.
• Prefer small focused functions and early returns over deeply nested branches.
• Use exported symbol doc comments when new public types or functions are introduced.
• Avoid reflection or any when concrete types or small interfaces are clearer.