04-review-and-commit

---

Review and Completion

Implementation is not complete until it has been:

• validated;
• independently reviewed;
• documented;
• accepted.

Review is a mandatory engineering stage of the project lifecycle.

---

Completion Workflow

Plan Implementation
        ↓
Validation
        ↓
Code Review
        ↓
Documentation Update
        ↓
Progress Update
        ↓
Commit

Do not skip review unless explicitly instructed.

---

Review Scope

Review the implementation against:

• the approved implementation plan;
• PROJECT.md;
• ROADMAP.md;
• ARCHITECTURE.md;
• ENGINEERING.md;
• relevant ADRs;
• acceptance criteria.

Focus on:

• correctness;
• completeness;
• maintainability;
• engineering consistency;
• architectural compliance;
• scope compliance.

---

Scope Verification

Confirm that:

• only approved functionality has been implemented;
• no undocumented functionality has been introduced;
• architectural boundaries have been respected;
• engineering conventions have been followed;
• implementation remains within the approved scope.

Reject unnecessary scope expansion.

---

Documentation Verification

Before completing the work, verify whether updates are required for:

• ARCHITECTURE.md;
• ENGINEERING.md;
• ADRs;
• implementation plans;
• RUNBOOK.md;
• PROGRESS.md.

Repository knowledge should remain internally consistent.

---

Validation

Perform all project-required validation.

Typical validation includes:

• formatting;
• linting;
• type checking;
• automated tests;
• manual verification.

Use the validation commands documented in ENGINEERING.md.

---

Progress Update

When implementation is approved:

• update PROGRESS.md when appropriate;
• complete the implementation checklist;
• move completed plans according to the documented plan lifecycle.

Project history should accurately reflect completed work.

---

Commits

Create commits only when explicitly requested.

Before committing, verify:

• validation has completed successfully;
• documentation is synchronized with implementation;
• review findings have been addressed;
• no temporary code remains;
• the repository is internally consistent.