code-review

Code Review Guidelines

Review Process

• Before Starting Review:

  • Check task requirements and acceptance criteria
  • Review related tasks and dependencies
  • Understand the context of the changes

• During Review:

  • Follow checklist systematically
  • Document findings clearly
  • Provide constructive feedback
  • Reference specific rules when applicable

• After Review:

  • Verify fixes address all comments
  • Check if changes require task updates
  • Update documentation if needed

Review Checklist

Architecture & Structure

// ✅ DO: Proper server action structure
// app/actions/organization/create.ts
'use server'
import { createOrganization } from '@/lib/data/mutations/organizations'

// ❌ DON'T: Mix concerns
'use server'
import { db } from '@/db'
// Direct database operations in server action

• Next.js 15 app directory structure
• Server actions in app/actions/
• Database operations in lib/data/{queries,mutations}/
• shadcn/ui component patterns
• SOLID principles adherence
• Clean data access patterns

Database & Data Layer

// ✅ DO: Use Drizzle migrations
// db/migrations/0001_initial.ts
import { sql } from 'drizzle-orm'

// ❌ DON'T: Manual SQL files
// migrations/manual.sql
CREATE TABLE users...

• Generated Drizzle migrations
• Proper RLS policies
• Edge function security
• PostgreSQL style compliance
• Type-safe database operations
• Query optimization

Server Actions & API

// ✅ DO: Proper server action
export async function createUser(input: CreateUserInput) {
  const result = await createUserMutation(input);
  if (result.error) {
    return { error: result.error };
  }
  return { data: result.data };
}

// ❌ DON'T: Skip validation/typing
export async function createUser(formData: any) {
  const user = await db.users.create(formData);
  return user;
}

• 'use server' directive present
• Abstracted database operations
• Comprehensive error handling
• Zod schema validation
• Proper async patterns
• Appropriate response handling