test_suite_integrity

Test Suite Integrity Rule

All tests in the entire test suite must pass. Never skip addressing a failing test, even if it appears unrelated to the current task.

Core Principle

• The test suite is the foundation of code quality and system reliability
• Every failing test represents a potential bug or broken functionality
• Ignoring "unrelated" test failures leads to technical debt and system instability
• Test suite integrity is a prerequisite for any code changes

Implementation Requirements

✅ DO: Always Fix All Failing Tests

# ✅ Run full test suite before any implementation
python -m pytest tests/ -v

# ✅ Fix ALL failing tests, not just related ones
python -m pytest tests/ -x --tb=short

# ✅ Verify test suite health after changes
python -m pytest tests/ --tb=short

✅ DO: Address Test Failures by Priority

1. Critical System Tests: Core functionality, integration tests
2. Unit Test Failures: Individual component failures
3. Edge Case Tests: Boundary condition tests
4. Documentation Tests: Import tests, structure validation

✅ DO: Update Tests When Implementation Changes

# ✅ Update test expectations to match new behavior
def test_enhanced_hook_content():
    """Updated test for enhanced git hook functionality."""
    content = generate_hook_content()
    assert "python -m mcp_commit_story.git_hook_worker" in content
    assert '"$PWD"' in content

✅ DO: Maintain Backward Compatibility Tests

# ✅ Keep backward compatibility tests working
def test_custom_command_still_works():
    """Ensure legacy behavior still functions."""
    custom = "echo 'hello world'"
    content = generate_hook_content(custom)
    assert custom in content

❌ DON'T: Skip "Unrelated" Test Failures

# ❌ Wrong - ignoring failures
pytest tests/unit/test_my_feature.py  # Only testing related code

# ❌ Wrong - proceeding with failures
# "The git_utils tests are failing but that's not related to my change"