angular-api-client-codegen

Standard IDs

ID	Severity	What it checks
ACG-001	P1	Hand-typed TS interfaces re-declared per feature instead of a generated client from the OpenAPI spec
ACG-002	P1	Generated client checked in but not regenerated in CI — drifts silently from the live API
ACG-003	P2	Hand-written HttpClient calls duplicate endpoints the generated client already exposes
ACG-004	P2	No CI step fails the build when the OpenAPI spec changes without the client being regenerated

---

Check A — Hand-typed interfaces instead of a generated client (ACG-001)

Detection

Grep feature directories for TypeScript interfaces that mirror a C# DTO field-for-field (interface OrderDto { id: string; customerName: string; total: number }) declared by hand in more than one place. Every backend DTO is a generation target from the OpenAPI spec that dotnet-dto-mapping already produces — hand-typing it a second time on the frontend means the two copies drift the moment either side adds a field, and nothing catches it until a runtime undefined.

BAD — TS interface hand-typed to match the backend DTO, redeclared per feature

// features/orders/models/order.model.ts
export interface Order {
  id: string;
  customerName: string;
  total: number;
}
// features/order-history/models/order-summary.model.ts — a second, slightly different hand-typed copy
export interface OrderSummary {
  id: string;
  customer: string;   // renamed by hand, now inconsistent with the actual DTO field name
  total: number;
}

GOOD — generated client is the single source of truth for request/response types

// nswag.json generates this file — never hand-edited
import { OrderDto, OrdersClient } from '@myorg/api-client';

@Injectable({ providedIn: 'root' })
export class OrderService {
  private readonly client = inject(OrdersClient);

  getOrder(id: string): Observable<OrderDto> {
    return this.client.getOrder(id); // OrderDto's shape always matches the live C# contract
  }
}