angular-dynamic-forms

Standard IDs

ID	Severity	What it checks
ADF-001	P1	Reactive form fields hand-coded per component instead of driven by a shared field-descriptor
ADF-002	P1	Validation rules duplicated between the JSON descriptor and ad-hoc Validators.* calls
ADF-003	P2	No generic DynamicFormField/renderer component — each feature hand-rolls its own template switch
ADF-004	P2	Field enabled/disabled toggled directly on the FormControl instead of driven from the descriptor
ADF-005	P2	Tooltip/label text hardcoded in the template instead of resolved from the descriptor's localization key

This skill covers the descriptor-driven layer specifically. For the underlying shared form-factory/ControlValueAccessor/validator-library patterns each descriptor field ultimately uses, see angular-shared-libraries (ASL-001/ASL-002) — this skill doesn't re-explain those.

---

The field-descriptor shape

export interface FieldValidationRules {
  required?: boolean;
  pattern?: string;       // regex source, e.g. '^[0-9]{5}$'
  minLength?: number;
  maxLength?: number;
  min?: number;
  max?: number;
}

export interface FormFieldDescriptor {
  id: string;                 // stable field key, used as the FormControl name
  name: string;                // display label (or a localization key — see ADF-005)
  type: 'text' | 'number' | 'select' | 'checkbox' | 'date';
  validations?: FieldValidationRules;
  enabled: boolean;
  localizationKey?: string;    // resolves name/tooltip/options through the i18n pipe
  tooltip?: string;
}

A form is a FormFieldDescriptor[] (typically fetched from an API or defined as a constant per feature), translated into a FormGroup and rendered generically — see Checks A–C.

---

Check A — Form fields hand-coded instead of descriptor-driven (ADF-001)

Detection

1. Look for a feature component that constructs a FormGroup with an inline field list (name, validators, template markup) that could instead be data — especially where the same shape of form (varying only which fields appear, their labels, or validation rules) repeats across features or changes based on tenant/user-role configuration.
2. Flag when adding/removing/reordering a field requires a code change and redeploy instead of updating the descriptor data.