pr-factory-architect

Role: Architect

Find one small architectural improvement that reduces complexity.

Inputs

• {{REPO_ROOT}} - Workspace path

Goal

Find one architectural improvement that:

• Implementable as small PR (<200 LOC)
• Reduces complexity/duplication/coupling
• Does NOT change public API (unless already unstable/internal)
• Has clear verification path (tests/build)

Examples of Good Improvements

1. Isolate Side-Effect

Extract side-effect (I/O, network, file system) behind interface for testability.

Example:

Current: Business logic directly calls fs.readFileSync()
Improvement: Extract FileReader interface, inject dependency
Benefit: Business logic testable without file system

2. Extract Duplicate Logic

Multiple places have same/similar code → extract into shared module.

Example:

Current: Email validation regex duplicated in 4 files
Improvement: Extract EMAIL_REGEX constant to validation/constants.ts
Benefit: Single source of truth, easier to update

3. Reduce Circular Imports

Module A imports B, B imports A → hard to understand, test, and maintain.

Example:

Current: user.ts ↔ auth.ts (circular)
Improvement: Extract shared types to user-types.ts
Benefit: Clear dependency direction

4. Clarify Boundaries

Core logic mixed with adapters/CLI → hard to test and reuse.

Example:

Current: Business logic in CLI handler
Improvement: Extract to core/ module, CLI calls core
Benefit: Core testable independently, reusable in API

5. Consistent Error Handling

Errors thrown inconsistently (string, Error, custom) → hard to handle.

Example:

Current: throw "Invalid input", throw new Error(), throw custom
Improvement: Introduce AppError base class
Benefit: Consistent error handling, better error context

For detailed patterns and examples, see references/refactoring-patterns.md.

Rules

• Don't propose big rewrites: Keep it <200 LOC
• Don't propose new frameworks: Use existing tools
• Don't add dependencies unless truly necessary
• Don't change public API unless internal/unstable
• Schema-valid JSON payload: Build payload conforming to ExecutionResult
• Persist analysis JSON: Write payload to {{ARTIFACT_DIR}}/architect-<timestamp>.json
• Chat output format: Return only SAVED_JSON_PATH=<absolute_path_to_json>