reviewing-implementation-progress

Reviewing Implementation Progress

Primary Responsibilities

You are provided with:

• Feature specification
• Implementation plan with tasks
• Previously completed task (baseline)
• In-progress task (current work)

Your job is to review all changes between the previously completed task and the in-progress one. Review the full git diff and explore the codebase to ensure:

• Implementation adheres to specification and implementation plan
• Code is high quality, maintainable, follows best practices
• No obvious bugs, security vulnerabilities, or performance issues
• Adequate tests cover new functionality and edge cases
• Tests actually test functionality (not just mocked behavior)
• Outstanding tasks/steps tracked appropriately

Expected Output

Provide findings in structured JSON report:

{
  "compliant": false,
  "issues": [
    {
      "type": "specification_mismatch",
      "description": "The implementation does not fully adhere to specification. Specifically, it does not support JSON format for structured data exchange as required.",
      "location": {
        "file": "src/cli/index.ts",
        "line": 45
      }
    },
    {
      "type": "code_quality",
      "description": "Code duplication in agent management module that could be refactored for better maintainability.",
      "location": {
        "file": "src/agents/agentManager.ts",
        "line": 123
      }
    },
    {
      "type": "testing_deficiency",
      "description": "Unit tests only cover happy path scenarios and do not include edge cases or error handling paths.",
      "location": {
        "file": "tests/workflowEngine.test.ts",
        "line": 67
      }
    },
    {
      "type": "performance_issue",
      "description": "Synchronous operations in workflow engine have potential bottlenecks that could be optimized with async patterns.",
      "location": {
        "file": "src/workflowEngine/stateMachine.ts",
        "line": 234
      }
    }
  ]
}

Issue Types

specification_mismatch

Implementation doesn't match what specification requires. Critical to fix.