code-review

Code Review Skill

Comprehensive code review guidance for Tauri + Rust + React applications with focus on quality, security, and maintainability.

Overview

This skill provides systematic code review guidance covering:

• Correctness: Logic errors, edge cases, type safety
• Performance: Inefficient algorithms, resource leaks, optimization opportunities
• Security: SQL injection, XSS, unsafe operations, data validation
• Maintainability: Code duplication, naming, documentation, test coverage
• Tauri-specific: Command patterns, specta attributes, desktop app constraints
• Project-specific: Adherence to CLAUDE.md guidelines

When This Skill Applies

This skill activates when:

• Reviewing pull requests or code changes
• Performing code quality checks
• Looking for bugs and issues
• Suggesting refactoring opportunities
• Auditing security vulnerabilities
• Checking performance bottlenecks
• Ensuring compliance with project standards

Code Review Framework

1. Pre-Review Checklist

Before diving into code details:

# Check git diff context
git diff main...feature-branch
git log --oneline main..feature-branch

# Verify tests pass
cargo test
npm test

# Check formatting
cargo fmt --check
npm run lint

Questions to answer:

• What is the purpose of this change?
• What files are modified? (Use git diff --stat)
• Are there breaking changes?
• Is test coverage adequate?
• Does it follow project conventions?

2. Rust Backend Review

Command Pattern Review

✅ Correct Tauri Command:

#[tauri::command]
#[specta::specta]
pub async fn get_materials(
    state: State<'_, TauriAppState>,
) -> ApiResponse<Vec<Material>> {
    with_service(state, |ctx| async move {
        ctx.material_service.get_all().await
    })
    .await
}

Checklist:

• #[tauri::command] attribute present
• #[specta::specta] attribute present
• Return type is ApiResponse<T>
• Uses with_service helper or proper error handling
• Async functions properly use await