.NET and Angular Code Review Best Practices

Apply these best practices when reviewing .NET and Angular code. Focus on issues that matter - bugs, security vulnerabilities, and significant design problems. Avoid nitpicks and style preferences.

.NET Best Practices

Clean Architecture

Layer Dependencies (Strict):

• Domain: No dependencies (pure business logic)
• Application: Depends only on Domain
• Infrastructure: Depends on Application and Domain
• Presentation/API: Depends on Application (not Infrastructure directly)

Violations to flag:

• Domain layer importing Infrastructure namespaces
• Application layer directly instantiating Infrastructure classes
• Circular dependencies between layers
• Business logic in controllers or Infrastructure

SOLID Principles

Single Responsibility:

• Classes doing multiple unrelated things
• Methods longer than 30-50 lines
• Services mixing business logic with I/O operations

Open/Closed:

• Switch statements on type that could use polymorphism
• Modifying existing classes instead of extending

Liskov Substitution:

• Derived classes throwing NotImplementedException
• Overrides that don't honor base class contracts

Interface Segregation:

• Large interfaces forcing implementers to stub methods
• Classes depending on interfaces they don't fully use

Dependency Inversion:

• High-level modules instantiating low-level modules with new
• Depending on concrete classes instead of abstractions

Async/Await Patterns

Critical Issues (Always flag):

// BAD: Blocking on async
var result = GetDataAsync().Result;  // Deadlock risk
var result = GetDataAsync().Wait();  // Deadlock risk

// BAD: async void (except event handlers)
public async void ProcessData() { }  // Exceptions lost

// BAD: Missing await
public async Task ProcessAsync() {
    GetDataAsync();  // Fire and forget - bugs!
}

Correct Patterns:

// GOOD: Proper async/await
public async Task<Result> ProcessAsync() {
    var data = await GetDataAsync();
    return await TransformAsync(data);
}

// GOOD: ConfigureAwait in library code
var data = await GetDataAsync().ConfigureAwait(false);