daa-review

DAA Code Reviewer

REQUIRED BACKGROUND: You MUST understand daa:daa-core before using this skill.

Overview

Review automation test code against DAA principles. Classify each violation by severity and provide actionable fix suggestions.

Review Process

digraph review {
    rankdir=TB;
    "Read the code" [shape=box];
    "Classify into layers" [shape=box];
    "Check Test Layer rules" [shape=box];
    "Check Action Layer rules" [shape=box];
    "Check Physical Layer rules" [shape=box];
    "Check cross-layer boundaries" [shape=box];
    "Assign severity" [shape=box];
    "Report findings" [shape=doublecircle];

    "Read the code" -> "Classify into layers";
    "Classify into layers" -> "Check Test Layer rules";
    "Check Test Layer rules" -> "Check Action Layer rules";
    "Check Action Layer rules" -> "Check Physical Layer rules";
    "Check Physical Layer rules" -> "Check cross-layer boundaries";
    "Check cross-layer boundaries" -> "Assign severity";
    "Assign severity" -> "Report findings";
}

Quick Review Checklist (Top 10)

Run through these checks in order. Stop and flag immediately on any CRITICAL finding.

Test Layer

1. [CRITICAL] Does any test method contain if, for, while, or try/catch?
2. [CRITICAL] Does any test method make direct API/UI/DB calls (bypassing Action Layer)?
3. [WARNING] Does any test method contain assert statements (should be in Action Layer)?

Action Layer

1. [CRITICAL] Does any action method lack self-verification (no assertion after operation)?
2. [CRITICAL] Does any action method call the underlying library directly (bypassing Physical Layer)?
3. [WARNING] Are there Composite Actions that call Physical Layer directly instead of composing Atomics?
4. [WARNING] Do action names follow the verb_object_and_verify_outcome pattern?

Physical Layer

1. [CRITICAL] Does the Physical Layer contain any assertions or business logic?
2. [WARNING] Does any Physical Layer method perform multiple operations instead of one?