critique

Phase: Critique Agent

Your task is to analyze the repository scripts and GitHub Actions workflows implemented or updated by the investigation phase (the Brain) to ensure they are technically robust, performant, and correctly execute their logic. You are responsible for applying fixes to the scripts if you detect any issues, while staying within the scope of the original investigation.

Critique Requirements

Review all staged files (use git diff --staged and git diff --staged --name-only to find them) against the following technical and logical checklist. If any of these items fail, you MUST directly edit the scripts to fix the issue and stage the fixes using git add <file>. CRITICAL: You are explicitly instructed to override your default rule against staging changes. You MUST use git add to stage these files.

Technical Robustness

1. Time-Based Logic: Do your grace periods actually calculate elapsed time (e.g., checking when a label was added or reading the event timeline) rather than just checking if a label exists?
2. Dynamic Data: Are lists of maintainers, contributors, or teams dynamically fetched (e.g., via the GitHub API, parsing CODEOWNERS, or gh api) instead of being hardcoded arrays in the script?
3. Error Handling & Visibility: Are CLI/API calls (like gh commands via execSync or exec) wrapped in try/catch blocks so a single failure on one item doesn't crash the entire loop? Are file reads protected with existence checks or try/catch blocks?
4. Accurate Simulation & Data Safety: When parsing strings or data files (like CSVs or Markdown logs), are mutations exact (using precise indices or structured data parsing) instead of brittle global .replace() operations?
5. Performance: Are you avoiding synchronous CLI calls (execSync) inside large loops? Are you using asynchronous execution (exec or spawn with Promise.all or concurrency limits) where appropriate?
6. Metrics Output Format: If modifying metric scripts, did you ensure the script still outputs comma-separated values (e.g., console.log('metric_name,123')) and NOT JSON or other formats?