temps-split-module

Split a large module

Rust lets one type have several impl blocks in different modules of the same crate, so most god files can be split by moving code only: no renamed functions, no changed signatures, no "while I'm here" fixes. A move-only diff is cheap to review; a mixed one is not.

Context: docs/plans/crates-refactor-plan.md §4 P2 lists the target files and proposed modules; §7 decisions 1 and 2 set the test-file convention and the size limits. Typical god files: crates/temps-providers/src/services.rs, crates/temps-deployer/src/docker.rs.

Rules

• One file per PR, and nothing else in that PR. Fixes found while moving go in a later PR (note them in the PR description).
• No behaviour change. Same tests, same test count, same public paths.
• Keep the public API. Every path other code uses (crate::services::Foo, temps_x::services::Foo) still resolves, via pub use.
• Narrowest visibility that compiles. Never widen to pub to make a move work.
• Split by responsibility, along seams that already exist: separate trait impls, groups of methods that call each other, types and errors, helpers.

Target layout

Either form is used in this repo; follow the crate's existing style.

foo/mod.rs            # module docs, shared imports, types, pub use re-exports
foo/lifecycle.rs      # impl Foo { ... } - one responsibility
foo/restore.rs        # impl Foo { ... }
foo/tests.rs          # #[cfg(test)] mod tests; when the tests are large

Real examples:

• crates/temps-error-tracking/src/services/source_map_service.rs with source_map_service/{artifacts,build_credentials,debug_ids}.rs: mod debug_ids; plus pub use artifacts::{ArtifactAssembly, ...}; in the parent, and debug_ids.rs holding impl SourceMapService { pub(super) async fn symbolicate_debug_ids(..) }.
• crates/temps-monitoring/src/http_checks/mod.rs with automatic.rs, secret_history.rs, transport.rs, variable_history.rs: automatic.rs, secret_history.rs and variable_history.rs start with use super::*; and add an impl HttpChecksService block, sharing pub(super) items.
• Out-of-line tests: crates/temps-status-page/src/lib.rs declares #[cfg(test)] mod tests; and the tests live in crates/temps-status-page/src/tests.rs.