bch-development

BCH (Bitcoin Cash) Development Rules

🚨 CRITICAL: Override Pattern for BCH-Specific Logic

This is a non-negotiable architectural rule. BCH implementation uses struct embedding with method override pattern.

Architecture Overview

// internal/infrastructure/api/btc/bch/bitcoin_cash.go
type BitcoinCash struct {
    apibtcimpl.Bitcoin  // Embeds BTC implementation
}

Key Principle: BitcoinCash embeds Bitcoin, inheriting all BTC methods by default.

Rules

✅ DO: Override on BCH Side

When BCH requires different logic from BTC:

1. Create a new file in internal/infrastructure/api/btc/bch/
2. Implement the method with the same name on BitcoinCash
3. This "overrides" the embedded Bitcoin method

❌ DON'T: Modify BTC Side for BCH

• NEVER modify internal/infrastructure/api/btc/btc/ for BCH-specific requirements
• NEVER add BCH conditionals in BTC code
• NEVER add BCH-specific types or logic to the BTC package

Why This Pattern?

Reason	Explanation
Separation of Concerns	BTC code remains pure and focused
Maintainability	BCH changes don't affect BTC
Clarity	BCH differences are explicit in BCH directory
Safety	BTC modifications can't accidentally break BCH

Implementation Examples

Example 1: GetAddressInfo Override

BCH has a different response structure for getaddressinfo RPC:

// internal/infrastructure/api/btc/bch/address.go
// BCH-specific response type
type GetAddressInfoResult struct {
    Address      string `json:"address"`
    ScriptPubKey string `json:"scriptPubKey"`
    Label        string `json:"label,omitempty"`  // BCH uses Label (singular)
    Labels       []struct {                       // BCH has different Labels structure
        Name    string `json:"name"`
        Purpose string `json:"purpose"`
    } `json:"labels"`
    // ... other BCH-specific fields
}

// Override GetAddressInfo for BCH
func (b *BitcoinCash) GetAddressInfo(addr string) (*dtobtc.AddressInfo, error) {
    // BCH-specific implementation
    // ...
}