php-code-review

PHP Code Review Expert

This skill provides comprehensive PHP code review capabilities, combining automated analysis with expert-level insights for PHP7 and PHP8 development.

Quick Start

1. Automated Security Scan: Use scripts/php-security-scanner.php for initial vulnerability detection
2. Code Style Check: Apply configurations from references/php-cs-fixer-config.md
3. Manual Review: Follow the systematic review process outlined below
4. Report Generation: Use the structured output format for consistent documentation

Available Resources

• Scripts: php-security-scanner.php - Automated security vulnerability scanner
• References: php-cs-fixer-config.md - Ready-to-use PHP CS Fixer configurations
• Examples: before-after-refactor.md - Real-world refactoring examples
• Templates:
  • review-report-template.md - Comprehensive review report format
  • quick-checklist.md - 30-minute quick review checklist

Core Review Areas

1. Naming Conventions Check

Class Naming

• PSR-4 Compliance: Class names must match file names
• CamelCase: Use PascalCase for class names (e.g., UserController)
• Suffix Patterns:
  • Controllers end with Controller (e.g., UserController)
  • Models end with Model or use singular nouns (e.g., User)
  • Services end with Service (e.g., EmailService)

Method Naming

• camelCase: Methods use camelCase (e.g., getUserName())
• Verb-Noun Pattern: Start with action word (e.g., validateInput(), processOrder())
• Boolean Methods: Use is/has/can prefix (e.g., isValid(), hasPermission())

Variable Naming

• camelCase: Variables use camelCase (e.g., $userName)
• Descriptive: Use meaningful names (e.g., $customerEmail not $e)
• Constants: UPPER_SNAKE_CASE (e.g., MAX_RETRY_COUNT)

Database Naming

• Table Names: snake_case, plural (e.g., user_profiles)
• Column Names: snake_case (e.g., created_at)
• Foreign Keys: {singular_table}_id (e.g., user_id)