add-scored-audit

Add a scored audit check

A requirement that is not in an audit is a requirement that will silently regress. This skill adds one check the right way.

The rules a check must follow

1. Read, don't redeclare. Pull the value from design/design.json or a build-exported out/*.json artifact. NEVER hard-code a geometry constant in the audit (regex it from the build source or read the JSON). A duplicated constant drifts and the audit then verifies a fiction.
2. Assert an EXPECTED value, not existence. The gold guardrail: a wrong boolean still passes watertight + volume>0. So check that the as-built bbox / volume / CG / margin matches a known anchor within a tolerance — not merely that it is positive.
3. Three outcomes. PASS, WARN (an HONEST, documented shortfall — e.g. physics contradicting a marketing claim), or FAIL (a real violation that must gate). Never use WARN to bury a real FAIL.
4. Cross-check against an anchor. A derived number is only trustworthy when it agrees with an independent truth: a published [PUB] value, an analytic formula, or the REAL exported artifact.

Procedure

1. Open the project's audit.py. Identify (or add) the right section header (sec = "N section name").

2. Find the source of truth for the value being checked:

   • a [PUB] anchor or requirement in design/design.json, or
   • a build-exported artifact in out/ (bbox, volume, contact, section). If the build does not yet export what you need, add the export to the build FIRST (that is the source-of-truth discipline), then read it here.

3. Add the check. For a value-vs-anchor check, prefer the expect() helper:

   sec = "2 clearances"
   prop_clearance = COMP["prop"]["bboxMin"][2] - deck_top_z   # from out/*.json
   req = D["requirements"]["prop_clearance_min_mm"]["min"]
   check(sec, "prop clears deck", prop_clearance >= req,
         f"clearance {prop_clearance:.1f} mm >= req {req} mm")
   

   For an as-built-matches-design check (the gold rule), assert the expected value, not just presence: