go-review-pr

Go Review PR

Perform a diff-aware quality review of ALL changes in the current branch before opening a PR. This is the final quality gate — it checks everything that go-review-service checks, but scoped to the diff only.

Arguments

$ARGUMENTS should specify:

• Base branch (optional, default: main) — the branch to compare against

Step 1: Gather the Diff

# Get the base branch (default: main)
BASE=${1:-main}

# All changed files in this branch vs base
git diff --name-only $BASE...HEAD

# Full diff for context
git diff $BASE...HEAD

# Commits in this branch
git log --oneline $BASE..HEAD

Categorize changed files:

• Go source files (*.go, excluding *_test.go)
• Go test files (*_test.go)
• Migration files (migrations/*.sql)
• Frontend files (*.ts, *.tsx)
• Config files (*.json, *.yaml, *.toml, go.mod, go.sum)
• Documentation (*.md)

Step 2: Per-Service Analysis

For each service with changed files, read the changed files and run these checks:

Check A: Compilation

cd services/{service} && go build ./...

Check B: Tests Pass

cd services/{service} && go test ./... -count=1 -timeout 60s

Check C: Lint

cd services/{service} && golangci-lint run ./... 2>&1 || true

Step 3: Convention Checks (on diff only)

For each changed Go file, verify:

3.1 Code in English

• All new variable names, function names, comments, error messages are in English
• FAIL if Portuguese found in code (excluding string literals for user-facing messages)

3.2 JSON Tags snake_case

• All new struct fields with json:"" tags use snake_case
• FAIL if camelCase or PascalCase found in json tags

3.3 DB Tags Match Columns

• All new struct fields with db:"" tags use snake_case matching column names
• Cross-reference with migration files if available

3.4 Schema Prefix in SQL

• All SQL queries in repository files use {schema}.{table} format
• FAIL if any bare table name found (e.g., FROM members instead of FROM member.members)