swift-memory-storage-pro

Audit Swift code for memory and storage problems. This is the deep-review companion to the always-on apple-memory-management.md and apple-storage-management.md rules: the rules steer while writing; this skill traces ownership, footprint, and file placement across whole features. Report only genuine problems.

If asked to fix rather than review, make the changes directly and summarize them in the same file-by-file format.

Review process:

1. Leaks. For each type that stores closures, Tasks, Combine subscriptions, timers, observers, or delegates, trace who owns whom using references/retain-cycles.md. A cycle needs a path back to self; confirm it before reporting.
2. Footprint. Check image decoding, in-memory caches, collection loading, and extension budgets using references/memory-footprint.md.
3. Storage. For every file write, UserDefaults key, Keychain item, and disk cache, check the location, backup status, protection class, size cap, and privacy manifest reason using references/storage-layout.md.
4. Evidence. When the user reports a symptom (memory growth, jetsam exits, disk use), or before you claim a fix worked, use references/measuring.md to reproduce and confirm it with the memory graph, Instruments, MetricKit, or a leak test. Add a leak test for each cycle you fix.

For a partial review (only leaks, only storage), load only the matching reference.

Core Instructions

• A cycle is only a finding when you can name the path. self → cancellables → sink closure → self is a cycle; a [weak self] missing from a non-escaping or one-shot closure is not. Don't spray [weak self] everywhere as a "fix".
• Size findings in bytes. "Decodes a 4032×3024 photo for a 60pt thumbnail: ~48 MB per cell" is actionable; "large image" is not.
• Location findings name the consequence: backed up when it shouldn't be (iCloud bloat, App Review), purgeable when it shouldn't be (offline content disappears), readable while locked when it holds sensitive data.
• Severity by user impact: crash or data loss (jetsam on a common flow, secrets in plain files, offline content in Caches, missing privacy manifest reason) > degraded (leaked view models, unbounded cache growth, backup bloat) > hygiene (missing size cap on a small cache, no storage settings screen).
• Cross-reference, don't duplicate: actor isolation belongs to swift-concurrency-pro; Core Data and SwiftData store setup to coredata-swift6-pro / swiftdata-pro; logging what you measured to swift-logging-pro.