devflow-plan-critic

Skill: devflow-plan-critic

Purpose: Deep self-critique of a plan before transitioning planning → approval. The agent puts on the reviewer-hat and challenges its own work against 7 quality dimensions.

When to use

Invoke this skill before calling flow_update({currentState: 'approval'}). The pre-tool-use hook prints a reminder, but the responsibility is on the agent: a plan submitted without critique is a plan submitted blind.

The 7 Dimensions

For each dimension, the critic answers a focused question and reports findings.

1. AC-Coverage

Does every Acceptance Criterion have at least one task that addresses it? Do tasks cover all ACs (no orphan tasks, no orphan ACs)?

Common failures:

• AC mentions a behavior but no task implements it ("user can edit X" → no UI task)
• Task exists for a sub-behavior not explicitly captured in any AC
• Acceptance Criterion is too vague to test ("should work well")

2. Task-Granularity

Is each task atomic and fits in less than a day's effort? Can each task be reviewed independently?

Common failures:

• "Implement feature X" — too coarse, should split into 3-5 tasks
• "Write tests" — too vague, should split into unit + integration + e2e
• One task touches >5 files in unrelated areas — likely needs splitting

3. Edge Cases

What happens at the boundaries? Empty input, concurrency, permissions, pre-existing state?

Common failures:

• No mention of empty/null/zero inputs
• Race conditions ignored (multi-user, multi-tab)
• Permission edge unstated ("user can do X" → who specifically? what role?)
• Migration/upgrade path for existing data missing

4. Wiki-Coverage

Are the relevant ADRs, patterns, and runbooks referenced in the plan? Does the plan drift from existing decisions?

Common failures:

• Plan introduces a pattern that contradicts an accepted ADR
• Plan reinvents something already documented as a pattern
• Plan affects an area that has runbooks, but doesn't reference them
• Plan extends behavior covered by an existing ADR but doesn't propose an ADR-update