acp-review-guidance

acp-review-guidance is a skill for Claude Code, Codex from openshift-online/agent-control-plane. It costs 48 tokens per session (705 once invoked), scanned A, original, MIT.

Repository-specific guidance for reviewing pull requests in the ACP project. It adds project conventions, security requirements, and backend and frontend checklists to a general pull-request review.

In plain words
What is it for?
Use it when reviewing ACP pull requests, especially changes to Go services, Kubernetes resources, React, or TypeScript.
Why use it?
It helps reviewers catch project-specific risks that a general code review may miss, such as unsafe Kubernetes access, leaked tokens, weak types, or incorrect resource ownership.

Skill for Claude CodeCodex

Written for no agent in particular: nothing here depends on one. Also seen: mentions CLAUDE.md.

Good fit Use it when reviewing ACP pull requests, especially changes to Go services, Kubernetes resources, React, or TypeScript.

Compare 6 skills from other repositories ↓
Install with agentmods
npx agentmods add skills/openshift-online/agent-control-plane/acp-review-guidance
Install

Getting it into your agent

One page per mod, every tool's command on it. A separate URL per tool would split the same page into five that compete with each other.

Any agent
npx skills add openshift-online/agent-control-plane --skill acp-review-guidance
Clone the repo
git clone --depth 1 https://github.com/openshift-online/agent-control-plane

Made for: Claude Code, Codex.

Wrote this? Show the measurements

A badge with what this costs and how it scanned, read live from this page, so it follows the numbers instead of freezing them. Markdown for a README, HTML for a documentation site or a project page.

agentmods badge for acp-review-guidance

README.md
[![agentmods](https://agentmods.dev/badge/skills/openshift-online/agent-control-plane/acp-review-guidance/github.svg)](https://agentmods.dev/skills/openshift-online/agent-control-plane/acp-review-guidance)
Your own site
<a href="https://agentmods.dev/skills/openshift-online/agent-control-plane/acp-review-guidance"><img src="https://agentmods.dev/badge/skills/openshift-online/agent-control-plane/acp-review-guidance/github.svg" alt="Measured on agentmods" height="20"></a>

Or the 80×15 button, for a site that already has a row of RSS and ATOM ones. Only the verdict fits; the numbers stay here.

agentmods 80×15 button for acp-review-guidance

Your own site · 80×15
<a href="https://agentmods.dev/skills/openshift-online/agent-control-plane/acp-review-guidance"><img src="https://agentmods.dev/badge/skills/openshift-online/agent-control-plane/acp-review-guidance.svg" alt="Reviewed on agentmods" width="80" height="20"></a>
Per session 48 Skills are progressive disclosure: only the name and description are preloaded; the body loads when the skill is used.
When invoked 705 The whole file, excluding the scripts and references it only reads on demand.
Security scan A 0 findings. A grade says what 26 rules found in the file — not that it is safe.
Origin original No closer match found in the catalogue.
Token cost

What it costs to keep this loaded

Counted locally with the o200k_base tokenizer, which is exact for GPT models; Claude uses its own tokenizer and its counts differ. Treat this as one consistent yardstick across the catalogue rather than a bill. Prices are per million input tokens.

ModelPer sessionOnce invoked
Fable 5.1 $0.00048 $0.00705
Opus 5 $0.00024 $0.00352
Sonnet 5 $0.00010 $0.00141
Haiku 4.5 $0.00005 $0.00071

Measured 11d ago against content hash 60994d7c0b10, method: parsed. Prices are Anthropic first-party input rates as of 2026-09-11, from the pricing page.

Security

Grade A, and why

acp-review-guidance scanned grade A with 0 findings against 26 rules in 11 categories — prompt injection, anti-refusal, data exfiltration, privilege escalation, supply chain, agent snooping, system-prompt leakage, SSRF and excessive agency — measured 11d ago.

A static scan of the body, not an audit. Every finding is printed with the line that produced it so you can judge whether it matters here. A mod is markdown that instructs an agent; that is exactly why what it instructs is worth reading.

Nothing flagged

None of the 26 patterns this scan looks for appear in this file: no shell pipes, no recursive deletes, no credential paths, no hidden text, no instruction-override or anti-refusal phrasing, no agent-config snooping. That is not a guarantee, it is the absence of the things that are checkable.

skills/review/acp-review-guidance/SKILL.md · 69 lines

How it starts

The opening of the file, as written. The whole thing — 69 lines — stays where its author put it; the contents beside it link to each section on GitHub.

ACP Review Guidance

Apply these standards in addition to the fleet pr-review skill when reviewing PRs in this repository. The pr-review skill defines the review process (summarize, worktree, context, analyze, report). This skill defines what to check during Steps 3 and 4 of that process.

Step 3 Supplement: Mandatory Context Files

Before analyzing any PR in this repo, load all of the following:

  1. CLAUDE.md
  2. specs/standards/security/security.spec.md
  3. specs/standards/control-plane/conventions.spec.md

Step 4 Supplement: ACP Review Checklists

Go Backend

  • All user operations use GetK8sClientsForRequest(c), never service account fallback
  • No tokens in logs — use len(token) for diagnostics
  • Type-safe unstructured access (unstructured.NestedMap, not direct assertions)
  • No panic() in production code — return fmt.Errorf with context
  • Errors wrapped: fmt.Errorf("context: %w", err)
  • errors.IsNotFound handled for 404 scenarios
  • OwnerReferences set on child resources (Jobs, Secrets, PVCs)

React/TypeScript Frontend

  • Zero any types — use proper types, unknown, or generic constraints
  • Shadcn UI components only — no custom buttons, inputs, dialogs
  • React Query for all data operations — no manual fetch() in components
  • type preferred over interface
  • Single-use components colocated with their page
  • Loading and error states handled
  • Query keys include all relevant parameters

Security (All Components)

  • RBAC check performed before resource access
  • No tokens or secrets in logs or error messages
  • Input validated (K8s DNS labels, URL parsing)
  • Log injection prevented — no raw newlines in logged user input
  • Generic error messages to users, detailed logs server-side
  • Container SecurityContext: AllowPrivilegeEscalation: false, Drop: ALL

General

  • No panic() in production Go code
  • No any types in frontend TypeScript
  • Feature flags gate new features (Unleash)
  • OwnerReferences on all new K8s child resources
  • New API endpoints have corresponding frontend proxy routes
  • PostgreSQL for persistent storage (not files)

Read the full file on GitHub · 69 lines

Files

What ships with it

1 file beside SKILL.md in the same directory: the scripts, references and assets a skill reads on demand. Not counted in the per-session cost; read them before you install if any of them is executable.

Changes

What this file has done since we first saw it

Hashed on every crawl. A supply-chain change to an agent config is a question of when, not whether, so the history is kept rather than the latest state alone.

  1. 11d ago First seen · 69 lines · 48 tokens per session scan A 60994d7c0b10

Subscribe to this mod's changes

acp-review-guidance is a skill published in the GitHub repository openshift-online/agent-control-plane (11 stars, last pushed yesterday), licensed MIT. It adds 48 tokens to every session and 705 once invoked, about $0.0002 per session on Opus 5. A static security scan graded it A with 0 findings. No closer match exists in the catalogue, so it is treated as the original; first seen 2026-08-31.