adversarial-tanstack

Adversarial TanStack Gate

A merge gate for TanStack Start + TypeScript web-app changes — a pass/fail gate: a single blind reviewer subagent judges the work against this gate's rules with an adversarial mandate, and the work passes only when every rule is PASS or N/A. This skill renders verdicts; it never fixes the work.

Rules are pinned to @tanstack/react-start 1.168+ (v1 RC, July 2026) and TypeScript 5.8–6.x semantics.

When to Apply

• A TanStack Start feature, route, or server function is about to merge and needs an objective PASS/FAIL, not advisory feedback.
• An agent (Claude, Codex) authored Start app code and you want an independent check its author bias cannot rubber-stamp.
• A diff touches the client/server boundary — env vars, loaders, server functions, auth — where a wrong PASS ships secrets or unauthorized data access.
• Auditing an existing Start codebase file set against the current v1 RC API surface (stale .inputValidator(), removed createServerFileRoute).

Do not apply to non-Start React apps (most serverfn/boundary/ssr rules will return N/A and the gate degenerates to a TypeScript check) or when the user wants explanations and refactors rather than a verdict.

Review Protocol

Follow these steps exactly — the gate's value is that every review runs the same way.

1. Identify the target. Pin down exactly what is under review (a diff, a set of files, a PR) and note the ref/paths so the review runs against an unambiguous, fixed target. Always include tsconfig.json, src/router.tsx, and src/start.ts (if present) in the target paths — several rules are decided by those files even when the diff does not touch them.
2. Load the rules. Read references/_sections.md and every rule file in references/ (all boundary-*.md, serverfn-*.md, sec-*.md, ssr-*.md, types-*.md, tscfg-*.md files).
3. Compose the reviewer prompt. Fill references/reviewer-prompt.md with the rules and the target. The composed prompt must be fully self-contained — a reviewer sees no conversation history, so nothing may refer to context outside the prompt.
4. Dispatch one blind reviewer. Launch a single Task subagent whose entire input is the composed prompt — no conversation context, no commentary alongside it.
5. Render fail-closed. The reviewer's structured output is the verdict — there is no merge step. Overall verdict is PASS only when every rule is PASS or N/A; any single FAIL fails the gate. Never average, weigh severity, or waive a rule — a "minor" FAIL is a FAIL.
6. Render the verdict. Fill assets/templates/verdict.md. On FAIL, aggregate the reviewer's "missing for PASS" suggestions into the fix list, each with its location, ordered by category importance. Every rule whose final result is FAIL must appear in the fix list with a change concrete enough to apply as written — if the reviewer's suggestion only restates the violation, derive the fix from the rule's Correct example before rendering.