goga-accept-manifest-review

goga-accept-manifest-review

Identity

The Agent verifies each Cell's CODEMANIFEST against its implementation during acceptance: code vs requirements, requirements vs code, manifest accuracy.

Core Principle

The Agent compares CODEMANIFEST with the actual implementation, updates the manifest as needed, and records any unresolvable discrepancies.

User Interaction Rule

Always provide response options. When addressing the User, always offer 2–4 concrete choices.

---

Algorithm

Step 1. Load Context

1. Load the Acceptance Scope Report.
2. Invoke skill goga-lang-disp to retrieve language conventions for the target language.
3. Load the DSL specification:
   • Invoke skill goga-cell to understand CODEMANIFEST DSL syntax, structural rules, and semantics.
   • Invoke skill goga-cookbook to understand principles for working with Cell and CODEMANIFEST files.
4. Invoke skill goga-codemanifest-base to retrieve baseline Usages and Annotations.

Step 2. Pre-flight Check

1. Run the linter: goga lint.
2. Record all errors as CRITICAL. Resolve them before proceeding.

Step 3. Per-Cell Review

Process each Cell listed in the Acceptance Scope Report:

Sub-step 1. Load Data

1. Read the Cell's CODEMANIFEST.
2. Parse all entities, methods, properties, imports, usages, annotations, re-exports, and locations per the goga-cell and goga-cookbook skill definitions.
3. Enumerate all source files (exclude .usages/, build artifacts, and test files).
4. Read every source file at its declared location.
5. Verify the Facade file exists.

Sub-step 2. Code Analysis

Question: Does the code satisfy the CODEMANIFEST requirements, baseline practices, and language conventions?

1. Run the contract comparison: goga contract <cell-path>.

2. For each Entity, compare:

   • Constructor Signature: CODEMANIFEST vs implementation.
   • Methods: CODEMANIFEST vs implementation — per method.
   • Properties: CODEMANIFEST vs implementation — per property.

3. For each Routine:

   • Signature match: contract result — CODEMANIFEST vs implementation.
   • Facade export: is the Routine exported through the Facade.

4. Check Facade exposure — every Entity must be present in the Facade.

5. Check code compliance with baseline Usages and Annotations from skill goga-codemanifest-base.

6. Check code compliance with language conventions from skill goga-lang-disp.