fundamental-ngx: Skill for Claude Code

PR Review: #$0

If $0 is empty or not a number, ask the user for a PR number before proceeding.

Context

Fetch the PR details:

• Diff: !gh pr diff $0
• PR info: !gh pr view $0
• Changed files: !gh pr diff $0 --name-only

Review Checklist

For each changed file, check the applicable sections below. Report findings grouped by severity: Blocking (must fix), Suggestion (should fix), Nit (optional).

1. Angular 22+ Patterns

• New code uses input() / output() / model() / linkedSignal(). Existing @Input() / @Output() decorators being modified should prefer migration to signal functions, but it's not blocking.
• host: {} in decorator — no @HostBinding() / @HostListener()
• @if / @for / @switch — no *ngIf / *ngFor / *ngSwitch
• No standalone: true in @Component (default since Angular 19)
• No allowSignalWrites option in effect() (the option no longer exists)
• DestroyRef + takeUntilDestroyed() — no custom DestroyedService
• computed() + host: { '[class]': } — no CssClassBuilder / @applyCssClass
• Member ordering: decorated props → signal inputs/outputs → public → protected → private → constructor → methods

2. State Management

• signal() only used when a reactive consumer exists (template, computed, effect, host binding)
• Plain properties for internal bookkeeping, one-time flags, cached values
• No redundant markForCheck() after signal updates
• BehaviorSubject → signal() where there are no async consumers
• effect() for signal reactions; RxJS only for async operations (HTTP, WebSocket, timers)
• No effect() used for state derivation — use computed() or linkedSignal instead
• linkedSignal used where mutable derived state is needed (not effect() + signal.set())
• No object/array mutation in place then signal.set() with same reference — always new references
• No conditional signal reads creating invisible dependency gaps in effect() / computed()