forge-review

Forge Review

Code review with fresh context. This skill is deliberately run without implementation context so it catches things the author missed due to familiarity bias.

Works in three modes:

• Pipeline mode — invoked with documentId, posts findings as issue comment, advances status
• Subagent mode — spawned by forge-code during Step 10, returns findings to caller
• Standalone mode — /forge-review with no args, reviews current branch diff

Usage

/forge-review <documentId>    # pipeline — review + post comment + set status
/forge-review                  # standalone — review current branch diff

Review Process

Pull-model note: On large issues forge_step_start returns a lean manifest (bodyTruncated:true). Fetch acceptanceCriteria/description as needed via forge_issues.get { documentId, fields: ['acceptanceCriteria'] } rather than assuming full body is present.

1. Get the Diff

In pipeline mode, first make sure you're looking at the right code: git fetch, then check out the issue's ISS-* branch (from the check-in bundle / sessionContext.branch, else git branch -r | grep ISS-XX). Then diff the branch's net change against the base branch — robust no matter how many implementation/fix commits exist:

git fetch origin
BASE=$(git merge-base origin/<baseBranch> HEAD)
git diff "$BASE"..HEAD --stat
git diff "$BASE"..HEAD
git log --oneline "$BASE"..HEAD

<baseBranch> comes from forge_config → get. Avoid HEAD~N — counting implementation-vs-review/fix commits is error-prone and reviews the wrong slice.

If there is no reviewable diff — empty output, no ISS-* branch, or the branch isn't reachable (not pushed / git fetch brought nothing) — you cannot review. Do NOT report "clean" and do NOT advance status: this is an ABSTAIN (see Pipeline Exit). A false "approve" on an unreviewable change is exactly the failure this gate exists to prevent (the ISS-144/148 class).

1b. Load the contract (pipeline mode)