pr-review-comments

PR Review Comments

Triage and address review comments on a pull request: read each comment, decide if valid, fix code, verify tests pass, reply, and resolve threads.

Prerequisites

• gh CLI authenticated
• Working directory inside the repo (or use --repo owner/repo)

Workflow

1. Fetch review comments

Get all review comments with context:

gh api repos/{owner}/{repo}/pulls/{pr}/comments \
  --jq '.[] | {id, path, line, body, user: .user.login}'

Also check top-level PR comments (non-inline):

gh api repos/{owner}/{repo}/issues/{pr}/comments \
  --jq '.[] | {id, body, user: .user.login}'

2. Triage each comment

For each comment, decide:

• Valid & actionable → fix the code
• Valid but won't fix → reply with rationale
• Invalid / misunderstanding → reply with explanation
• Question → answer it

Read the relevant file context before deciding. Don't blindly accept or reject.

3. Fix code

Apply fixes for valid comments. Group related fixes into a single commit. Use conventional commit style:

fix(<scope>): address PR review comments

- <summary of fix 1>
- <summary of fix 2>

Stage, commit, and push.

4. Validate tests pass

After fixing code, always run tests before pushing to make sure the fixes don't break anything:

• Run the project's test command (check project docs / CLAUDE.md / Makefile / mise tasks for the right command).
• If tests fail, fix the issue before pushing. A review fix that breaks CI is worse than the original comment.
• If the fix changes test expectations (e.g., updated output values), update the tests too.
• Pay special attention to mock/stub setups — removing or changing mocks can cause unrelated tests to fail when test infrastructure intercepts more than expected (e.g., mock_provider intercepting locally-evaluated data sources).

Only push once all tests are green.

5. Reply to comments

Reply to each review comment thread using the in_reply_to field: