tomtom-maps-mcp: Skill for Claude Code

A second reviewer for a finished change. The author's agent knows what the change meant to do, so it reads past what the diff actually does; a fresh subagent sees only the diff, the PR description and the repository. This skill is the main agent's procedure; the subagent's brief is docs/reviewer.md.

• Preflight is not this. tomtom-mcp-preflight runs the CI gates on your working diff before a commit. A review runs no gate, since CI does, and judges the change.
• The repository decides. Every comment rests on CODING_GUIDELINES.md, CONTEXT.md, an ADR, Adding_new_tools.md, or a traced failing scenario — never on taste.

The commands are POSIX shell: Git Bash on Windows. Run each gh command, and fetchPr.mjs, in a shell call of its own, with no redirect, pipe or $(...). Claude Code's sandbox hides gh's token, and .claude/settings.json takes these out of it only when the call holds nothing else.

Step 1: Resolve the target

Invoked with	Mode	Review root
#N, N, or a github.com/tomtom-international/tomtom-maps-mcp/pull/N link	PR	a worktree at the PR head
a branch name, --base <ref> optional	Local	a worktree, or in place when it is the current branch
nothing	Local, the current branch, uncommitted changes included	in place
--all, or --all <path>…	Local, whole files: every tracked file, or those under the paths	in place

Add --loop to a Local target on the current branch for loop mode, which Step 4 describes. Refuse it with a PR, another branch, or uncommitted changes to tracked files.

Refuse a PR link to any other repository. Then set up the inputs in one scratch directory:

REVIEW_DIR=$(mktemp -d "${TMPDIR:-/tmp}/tomtom-mcp-review.XXXXXX")
cp .agents/skills/tomtom-mcp-review/docs/reviewer.md "$REVIEW_DIR/"

In PR mode, fetch the PR with $TARGET, what the user gave: #N, N or a link. The script writes pr.json, threads.json and reviews.md, and prints N, BASE_REF, HEAD_SHA and DOCS_PRS for the rest:

node .agents/skills/tomtom-mcp-review/scripts/fetchPr.mjs "$TARGET" "$REVIEW_DIR"

DOCS_PRS lists the docs-portal PRs on the description's Docs portal: line (CODING_GUIDELINES.md § 10); one cited anywhere else is evidence, not a sibling. Each gets docs-<N>/ with the same three files, its diff.patch, and tree/, a sparse checkout of the MCP pages at its head. With no access, docs-<N>/unavailable.txt says why and the review goes on without it. In local mode, look the sibling up by its branch and fetch it alone:

gh pr list -R tomtom-internal/devportal-documentation --head tomtom-maps-mcp/<branch> --json number

node .agents/skills/tomtom-mcp-review/scripts/fetchPr.mjs --docs <number> "$REVIEW_DIR"

git fetch origin "${BASE_REF#origin/}" "pull/$N/head"
# Local mode: BASE_REF=${base:-origin/main}; HEAD_SHA=$(git rev-parse <branch>); git fetch origin main
BASE=$(git merge-base "$BASE_REF" "$HEAD_SHA")
git diff -U3 "$BASE" "$HEAD_SHA" > "$REVIEW_DIR/diff.patch"
git worktree add --detach "$REVIEW_DIR/tree" "$HEAD_SHA"   # skip when reviewing in place

• The brief is copied because a checkout, stash or branch switch in your tree during the review would otherwise take it away from a reviewer still reading it.
• pr.json carries the title and description, which the reviewer holds the diff to.
• threads.json and reviews.md keep a rerun from repeating itself: each review thread with its first comment and its latest three, where a "fixed in" reply lands, and the bodies of earlier agent reviews, which hold the findings no line could anchor.
• pull/$N/head fetches a PR from a fork as readily as one from a branch here.
• Base of a stacked PR is its baseRefName, another feature branch, so the diff is that PR's own slice. For a local branch in a stack, the user names --base.
• Reviewing in place, diff against the working tree instead (git diff -U3 "$BASE") and list git ls-files --others --exclude-standard into $REVIEW_DIR/untracked.txt: the subagent reads those in full.
• Whole files diff from the empty tree, so every line is a changed line, generated and vendored files left out. Write the paths in place of . when the user named some: