knowledge-review

Knowledge Review

You are the reviewer for one knowledge base pass. Code enforces every hard rule; you supply judgement as typed decisions with a confidence. Works from any agent: it is plain CLI plus JSON files.

Steps

1. Extract. Follow the knowledge-extract skill for changed sources (squadrant knowledge ingest <kb> --json, then apply).

2. Get the packet. squadrant knowledge review <kb> --json lists proposals (each with the live rule it replaces and any rules it conflicts with, plus priorities), stale rules, decided code-vs-doc conflicts, and open escalations.

3. Decide each item. Write decisions.json:

   { "decisions": [
     { "item": "biz.rounding.vnd-half-up@1a2b3c4d5e6f", "decision": "approve", "confidence": 0.92, "justification": "New revision states the same obligation with a tighter scope." },
     { "item": "stale:sec.logging.no-passwords", "decision": "approve", "confidence": 0.9, "justification": "Source section was removed." },
     { "item": "stale:biz.x", "decision": "reject", "confidence": 0.9, "justification": "Still stated in section 4.", "loc": "p.9 §4" }
   ], "pairs": [ { "a": "x", "b": "y", "relation": "duplicate", "keep": "x", "confidence": 0.9, "justification": "..." } ] }
   

   • decision: approve | reject | merge-into:<ruleId> | escalate. For stale: items, approve retires, reject keeps the rule active (optionally update loc).
   • confidence is 0..1. At or above autoApproveConfidence (packet field, default 0.8) code applies it; below, it is escalated. Be honest: a low number is useful.
   • Set "flag": true when you want a human regardless.
   • pairs (full pass only): classify the candidate pairs as duplicate | refines | conflicts | unrelated.

4. Code vs doc. Where a rule is contradicted by the project's code, add "codeConflict": {"project": "...", "files": ["src/x.ts"], "summary": "..."} to that rule's decision (use the live rule id as item if there is no proposal). Do not decide who is right. Code dates the conflict against the doc by git; if the code is newer it always goes to the operator, who is not asked again unless the doc or the anchored code changes. If the doc is newer it is recorded as a code violation.

5. Apply. squadrant knowledge review <kb> --apply decisions.json.

6. Close. squadrant knowledge reconcile <kb> [--full] --finish writes REPORT.md, advances the schedule and sends the captain a one-line count.