amethyst: Skill for Claude Code

Find Non-Lambda Log Calls

Overview

Three related logging hygiene issues:

1. Lambda overload missing. Log.d/i/w/e calls that use string interpolation without the lambda overload waste string allocation when the log level is filtered out in release builds.
2. Throwable dropped in catch blocks. Log.w/e calls inside catch (e: ...) blocks that interpolate ${e.message} but don't pass e lose the stack trace, and log nothing useful when e.message is null (NPE, IOException with no message, etc.).
3. Still on android.util.Log. Files importing the platform logger bypass Log.minLevel and the LogSink, and have no lambda overload — so neither fix above can be applied to them. Step 0 finds these; the last section migrates them.

When to Use

• After merging branches that add new logging
• Periodic audit of logging hygiene
• After migrating android.util.Log usages to the shared Log wrapper

What to Flag

Calls with string interpolation ($ in message) that do not pass a throwable:

// FLAG - interpolation without lambda, no throwable
Log.d("Tag", "Processing ${event.id}")
Log.w("Tag", "Failed for $url")

// IGNORE - passes throwable (lambda overload doesn't accept throwable)
Log.w("Tag", "Error: ${e.message}", e)
Log.e("Tag", "Failed for $url", throwable)

// IGNORE - no interpolation (no allocation benefit from lambda)
Log.d("Tag", "Initialization complete")

Search Commands

Important: Tags can be string literals ("Tag") or variables (tag, LOG_TAG). Run both patterns for each step.

The throwable-name alternation, used by Steps 2 and 3 — define it once and reuse it, rather than writing a shorter list in one step and a longer one in another:

THROWABLE='(e|t|it|ex|err|error|throwable|cause|tr)'

Filter the noise before counting, or the totals mislead: drop /build/, /androidTest/ and /src/test/ (release filtering doesn't apply to tests), and drop lines whose first non-space character is // or * — commented-out calls and KDoc examples both match these patterns. A grep -vE ':[0-9]+: *(//|\*)' handles the last one.